[Remove Vuetify from Studio] 'About collections' link and modal in Channels #5234#5245
Closed
ritoban23 wants to merge 2 commits into
Closed
[Remove Vuetify from Studio] 'About collections' link and modal in Channels #5234#5245ritoban23 wants to merge 2 commits into
ritoban23 wants to merge 2 commits into
Conversation
Member
|
Hello @ritoban23. These changes break Studio to the extent that it cannot be run. Also you use non-existing KDS APIs. I will now unassign you. If you wish to contribute, you're welcome to come back - before that, you will need to study referenced KDS documentation and existing codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes Vuetify from 'Learn about collections' button/link and 'About collections' modal in Channels > Collections.
Changes made-
ActionLinkwithKButtonusingbasic-linkappearanceMessageDialogwithKModalred--textclass with KDS palette-based colorKButtonVSpacercomponentManual verification-
Screenshots-

References
Fixes #5234
Reviewer guidance
-Login as user@a.com with password a
-Go to Channels > Collections