Conversation
Set default window size.
Collaborator
|
Can you set this to 1920x1080? Full HD is a reasonable standard. Also, the symbolic tests are failing. |
Collaborator
Author
|
Done. I forgot to synchronize the params in the symbolic model. Tests are fixed. |
mschuck-rai
approved these changes
Oct 9, 2025
amacati
approved these changes
Oct 9, 2025
Collaborator
amacati
left a comment
amacati
left a comment
There was a problem hiding this comment.
I adapted the comments to reflect your changes. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nominal yaw dynamics:
"yaw_acc": np.array([-60.0, -10.0, 120.0]),
So that the controller can stabilize unknown disturbances from numerical issues.
Otherwise, the drone starts spinning after a while, and we cannot control it.
Set default window size. Originally 480p, too small for visualization.
width: int = 1280,
height: int = 720,