cuSolver eigen decomposition support#189
Merged
Merged
Conversation
Add support for cuSolver's cusolverDn<t>syevd eigen decomposition as an alternative to CULA's implementation of LAPACK _geev.
Owner
|
Thanks for the contribution. Can you update the eig docstring with a note indicating that the CUSOLVER backend can only be used with symmetric/Hermitian input matrices? |
This reverts commit bcdebd1.
NVIDIA's cuSolver seems to only support symmetric/Hermitian matrix eigen decomposition. Making a note of that in the documentation. This should probably be addressed with a more proper fix at a later date, supporting general matrices like LAPACK geev does.
Sync up with mainline
This reverts commit afe447f.
Contributor
Author
|
I have finally made the requested updates in the docstring. I also reverted some extra commits I have made. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lebedov,
Seeing the CFFI work in #88, I do not know if there is value in adding cuSolver eigen decomposition support in the manner that I have, but I had found a need for the cuSolver support in skcuda.linalg.eig. I thought I might open a PR in case it was useful. There is likely more work to do since cuSolver doesn't seem to implement the LAPACK geev functionality like CULA and my approach seems to not work for complex matrices.
I am new to the project and would welcome any feedback on this.