Skip to content

Commit 5ebd360

Browse files
committed
ci(type-check): make ESLint setup explicit
Restore the explicit ESLint 9 setup that installs TypeScript 5 before build-types so ESLint 9's bundled types can be compiled. Also add a dedicated ESLint 8 branch and make unknown ESLint versions fail explicitly, so each supported major has a clear installation path in the workflow.
1 parent 587cb6a commit 5ebd360

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/type-check.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,17 @@ jobs:
6767
npm prune --omit=dev
6868
npm uninstall --no-save @types/eslint
6969
npm install --no-save --legacy-peer-deps eslint@^10 typescript@^5
70+
elif [ "${{ matrix.eslint_version }}" = "9" ]; then
71+
npm uninstall --no-save @types/eslint
72+
npm install --no-save eslint@^9 typescript@^5
73+
elif [ "${{ matrix.eslint_version }}" = "8" ]; then
74+
npm uninstall --no-save @types/eslint
75+
npm install --no-save eslint@^8
7076
elif [ "${{ matrix.eslint_version }}" = "7" ]; then
7177
npm install --no-save eslint@^7 @types/eslint@7.2.10
7278
else
73-
npm uninstall --no-save @types/eslint
74-
npm install --no-save eslint@^${{ matrix.eslint_version }}
79+
echo "unknown eslint_version: ${{ matrix.eslint_version }}"
80+
exit 1
7581
fi
7682
7783
- name: build types

0 commit comments

Comments
 (0)