Skip to content

Commit 69d05d9

Browse files
committed
test: document ESLint 10 RuleTester normalizations
Add inline comments explaining why the shared RuleTester helper strips legacy error.type fields from invalid cases and removes output/errors from valid cases under ESLint 10.
1 parent 40bb681 commit 69d05d9

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

tests/helpers/ruleTester.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ function convertToFlat(item, plugins) {
5252
function convertInvalidTest(item, plugins) {
5353
const newItem = convertToFlat(item, plugins);
5454

55+
// ESLint 10 no longer accepts `type` in expected error objects.
5556
if (eslintMajor >= 10 && Array.isArray(newItem.errors)) {
5657
newItem.errors = newItem.errors.map((error) => {
5758
if (!error || typeof error !== 'object' || !Object.prototype.hasOwnProperty.call(error, 'type')) {
@@ -70,6 +71,7 @@ function convertInvalidTest(item, plugins) {
7071
function convertValidTest(item, plugins) {
7172
const newItem = convertToFlat(item, plugins);
7273

74+
// ESLint 10 rejects legacy valid-test extras that older RuleTester versions tolerated.
7375
if (eslintMajor >= 10 && newItem && typeof newItem === 'object') {
7476
delete newItem.errors;
7577
delete newItem.output;

0 commit comments

Comments
 (0)