Skip to content

Commit 6a094a6

Browse files
committed
Pin TypeScript to 5.8.3 for ESLint 10 CI stability
Pinning avoids parser incompatibilities with TypeScript 5.9.x when using @typescript-eslint/parser@canary. Remove this pin once canary is no longer needed.
1 parent 7e21dfb commit 6a094a6

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/eslint-9+.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,14 @@ jobs:
5050
with:
5151
node-version: ${{ matrix.node-version }}
5252
after_install: |
53-
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}" "typescript@5"
53+
# Temporary: with ESLint 10 + @typescript-eslint/parser@canary,
54+
# TypeScript 5.9.x currently causes parser incompatibilities in CI.
55+
# Pin to 5.8.x for stability, and remove this pin once we move off canary.
56+
npm install --no-save \
57+
"eslint@${{ matrix.eslint }}" \
58+
"@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || matrix.typescript-eslint }}" \
59+
"babel-eslint@${{ matrix.babel-eslint }}" \
60+
"typescript@5.8.3"
5461
skip-ls-check: true
5562
- run: npx ls-engines
5663
- run: npm run unit-test

0 commit comments

Comments
 (0)