Skip to content

Commit ce2e7c7

Browse files
committed
ci(eslint-9+): only force TypeScript 5 for ESLint 10
ESLint 9 test jobs will continue to run using the repository’s default TypeScript version. Since the ESLint 9 matrix uses `typescript-eslint-parser`, forcing TypeScript 5 will cause fatal parsing errors during unit tests. Overrides to TypeScript 5 should be limited to ESLint 10.
1 parent 552af68 commit ce2e7c7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/eslint-9+.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
with:
5151
node-version: ${{ matrix.node-version }}
5252
after_install: |
53-
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}" "typescript@5"
53+
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}"${{ matrix.eslint == 10 && ' "typescript@5"' || '' }}
5454
skip-ls-check: true
5555
- run: npx ls-engines
5656
- run: npm run unit-test

0 commit comments

Comments
 (0)