feat: enable Snakemake benchmark files for DSP-running rules#146
Merged
Conversation
Add benchmark: directives to every rule that executes DSP processing (tier build and parameter generation, geds and spms, dsp and psp). Adds two pattern helpers (get_pattern_benchmark and get_pattern_benchmark_channel) mirroring the log helpers, and a new tmp_benchmark path so files live alongside logs and get cleaned with the rest of tmp/.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
- Coverage 64.84% 64.70% -0.15%
==========================================
Files 7 7
Lines 623 629 +6
==========================================
+ Hits 404 407 +3
- Misses 219 222 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark:directives to every rule that executes DSP processing (tier build and parameter generation, geds and spms, dsp and psp). Snakemake will write per-rule wall-time / memory TSVs alongside the existing logs.tmp_benchmarkpath,tmp_benchmark_path()helper, andget_pattern_benchmark/get_pattern_benchmark_channelmirroring the existing log helpers.pht/fast.py(save_dict_to_filescall).Rules instrumented
dsp.smk→build_dsppsp.smk→build_pspdsp_pars_spms.smk→build_pars_dsp_tau_spmsdsp_pars_geds.smk→build_pars_dsp_pz_geds,build_pars_evtsel_geds,build_pars_dsp_nopt_geds,build_pars_dsp_dplms_geds,build_pars_dsp_eopt_gedspsp_pars_geds.smk→build_par_psp_fallback,build_pars_psp_dplms_geds_fallbackThe SVM training rules (
build_svm_dsp_geds,build_pars_dsp_svm_geds, and PSP svm equivalents) are intentionally skipped — they don't run DSP on data.Test plan
pytest tests/passesgenerated/tmp/benchmark/<time>/<step>/*.tsvfiles appear and contain sensible numbers