siunitx and threeparttable are compatible, remove automatic deactivation of siunitx#208
Open
mrpg wants to merge 4 commits into
Open
siunitx and threeparttable are compatible, remove automatic deactivation of siunitx#208mrpg wants to merge 4 commits into
mrpg wants to merge 4 commits into
Conversation
leifeld
requested changes
Jul 23, 2024
Collaborator
leifeld
left a comment
leifeld
left a comment
There was a problem hiding this comment.
Great, thank you! Can you also modify the line expect_warning(texreg(model1, threeparttable = TRUE, siunitx = TRUE), "Switching off 'siunitx'.") in test-texreg.R to verify that both packages together work? I am happy to accept the PR once the package is checked without errors.
Author
|
Done in 03f4aac, thank you! |
Collaborator
|
Well, you deleted the check, but it would be good to have a unit test that verifies that both packages actually work together without error or warning. Can you re-insert and then revise the line you deleted to that effect? I'm not going to blindly accept a PR without having a unit tests that shows it's working as intended. Thanks. |
Author
|
Added with 0d08917. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the automatic deactivation of siunitx when it is used with threeparttable. Both packages are indeed compatible. Related issue: #146