Add timeouts for outbound HTTP requests

Author: nikdoof

hackspaceapi/services/homeassistant.py

@@ -30,7 +30,7 @@ def call_homeassistant(endpoint: str, **params) -> Optional[Iterable]:
     """
     url = urljoin(str(settings.homeassistant_instance), endpoint)
     try:
-        resp = session.get(url, params=params)
+        resp = session.get(url, params=params, timeout=5)
         if resp.ok:
             return resp.json()
     except requests.exceptions.RequestException as exc:

hackspaceapi/services/prometheus.py

@@ -25,7 +25,7 @@ def get_prometheus_metric(query: str) -> Optional[Dict]:
     """
     url = urljoin(str(settings.prometheus_instance), "/api/v1/query")
     try:
-        resp = session.get(url, params={"query": query})
+        resp = session.get(url, params={"query": query}, timeout=5)
         if resp.ok:
             data = resp.json()
             if "status" in data and data["status"] == "success":

hackspaceapi/services/website.py

@@ -25,7 +25,7 @@ def get_membership_data() -> Optional[Iterable]:
     """
     url = urljoin(str(settings.hackspace_website_url), "/membership/index.json")
     try:
-        resp = session.get(url)
+        resp = session.get(url, timeout=5)
         if resp.ok:
             data = resp.json()
             return data["memberships"]