Fix RawStmt stmt_len with Unicode statements#194
Open
alexmac wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7 #194 +/- ##
=====================================
Coverage ? 99.55%
=====================================
Files ? 22
Lines ? 7259
Branches ? 0
=====================================
Hits ? 7227
Misses ? 32
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexmac
force-pushed
the
alex/fix-rawstmt-stmt-len-unicode
branch
from
78c75fe to
8ebbf85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RawStmt.stmt_len was being run through the byte-offset-to-string-index mapper as if it were an absolute offset, but PostgreSQL reports it as a length relative to stmt_location. That works by accident for plain ASCII, but in multi-statement SQL with Unicode earlier in the string, the length gets shortened because it’s converted from byte offset stmt_len instead of from the real byte end position stmt_location + stmt_len.
The fix converts both byte positions, start and end, into Python string indexes, then subtracts them. So stmt_len stays a character length that can be used with sql[stmt_location:stmt_location + stmt_len], even when earlier statements contain multibyte characters like €.