Skip to content

Commit 45d7759

Browse files
Brendonovichleohenon
authored andcommitted
fix(app): use keyed Show for project in layout (anomalyco#26985)
1 parent c30f06a commit 45d7759

1 file changed

Lines changed: 7 additions & 14 deletions

File tree

packages/app/src/pages/layout.tsx

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2097,6 +2097,7 @@ export default function Layout(props: ParentProps) {
20972097
</div>
20982098
</Show>
20992099
}
2100+
keyed
21002101
>
21012102
{(project) => (
21022103
<>
@@ -2107,9 +2108,7 @@ export default function Layout(props: ParentProps) {
21072108
id={`project:${projectId()}`}
21082109
value={projectName}
21092110
onSave={(next) => {
2110-
const item = project()
2111-
if (!item) return
2112-
void renameProject(item, next)
2111+
void renameProject(project, next)
21132112
}}
21142113
class="text-14-medium text-text-strong truncate"
21152114
displayClass="text-14-medium text-text-strong truncate"
@@ -2151,9 +2150,7 @@ export default function Layout(props: ParentProps) {
21512150
<DropdownMenu.Content class="mt-1">
21522151
<DropdownMenu.Item
21532152
onSelect={() => {
2154-
const item = project()
2155-
if (!item) return
2156-
showEditProjectDialog(item)
2153+
showEditProjectDialog(project)
21572154
}}
21582155
>
21592156
<DropdownMenu.ItemLabel>{language.t("common.edit")}</DropdownMenu.ItemLabel>
@@ -2163,9 +2160,7 @@ export default function Layout(props: ParentProps) {
21632160
data-project={slug()}
21642161
disabled={!canToggle()}
21652162
onSelect={() => {
2166-
const item = project()
2167-
if (!item) return
2168-
toggleProjectWorkspaces(item)
2163+
toggleProjectWorkspaces(project)
21692164
}}
21702165
>
21712166
<DropdownMenu.ItemLabel>
@@ -2224,7 +2219,7 @@ export default function Layout(props: ParentProps) {
22242219
<div class="flex-1 min-h-0">
22252220
<LocalWorkspace
22262221
ctx={workspaceSidebarCtx}
2227-
project={project()}
2222+
project={project}
22282223
sortNow={sortNow}
22292224
mobile={panelProps.mobile}
22302225
/>
@@ -2239,9 +2234,7 @@ export default function Layout(props: ParentProps) {
22392234
icon="plus-small"
22402235
class="w-full"
22412236
onClick={() => {
2242-
const item = project()
2243-
if (!item) return
2244-
void createWorkspace(item)
2237+
void createWorkspace(project)
22452238
}}
22462239
>
22472240
{language.t("workspace.new")}
@@ -2268,7 +2261,7 @@ export default function Layout(props: ParentProps) {
22682261
<SortableWorkspace
22692262
ctx={workspaceSidebarCtx}
22702263
directory={directory}
2271-
project={project()}
2264+
project={project}
22722265
sortNow={sortNow}
22732266
mobile={panelProps.mobile}
22742267
/>

0 commit comments

Comments
 (0)