fix all ESLint 9 and unicorn linting issues

- Replace && expressions with if statements to avoid unused expressions
- Use structuredClone instead of JSON.parse(JSON.stringify())
- Replace forEach with for...of loops
- Replace Array.reduce() with for...of loops or flatMap
- Replace .concat() with template literals or spread operators
- Use logical operators instead of ternary where appropriate
- Pass inline arrow functions instead of direct function references to map()
- Add error messages to Error constructors
- Disable unicorn/consistent-function-scoping for debounced MobX action

Author: leonardoventurini

src/Analytics.ts

@@ -110,10 +110,10 @@ export class Analytics {
   }
 
   set(key: string, value = null) {
-    if (value !== null) {
-      this.customParams[key] = value
-    } else {
+    if (value === null) {
       delete this.customParams[key]
+    } else {
+      this.customParams[key] = value
     }
   }
 
@@ -144,7 +144,6 @@ export class Analytics {
     if (label) params.el = label
     if (value) params.ev = value
 
-    // eslint-disable-next-line no-console
     this.send('event', params).catch(console.error)
   }
 
@@ -257,27 +256,24 @@ export class Analytics {
       .then(res => {
         let response = {}
 
-        if (res.headers.get('content-type') !== 'image/gif') {
-          response = res.json()
-        } else {
-          response = res.text()
-        }
+        response =
+          res.headers.get('content-type') === 'image/gif'
+            ? res.text()
+            : res.json()
 
         if (res.status === 200) {
           return response
         }
 
-        return Promise.reject(new Error(response as string))
+        throw new Error(response as string)
       })
       .then((json: any) => {
-        if (this.globalDebug) {
-          if (json.hitParsingResult[0].valid) {
-            return { clientId: payload.cid }
-          }
+        if (this.globalDebug && json.hitParsingResult[0].valid) {
+          return { clientId: payload.cid }
         }
 
         return { clientId: payload.cid }
       })
-      .catch(err => new Error(err))
+      .catch(error => new Error(error))
   }
 }

src/App.tsx

@@ -10,10 +10,10 @@ import './Styles/App.scss'
 
 FocusStyleManager.onlyShowFocusOnTabs()
 
-const panelElement = document.getElementById('panel')
-const optionsElement = document.getElementById('options')
-const popupElement = document.getElementById('popup')
+const panelElement = document.querySelector('#panel')
+const optionsElement = document.querySelector('#options')
+const popupElement = document.querySelector('#popup')
 
-panelElement && render(<Panel />, panelElement)
-optionsElement && render(<Options />, optionsElement)
-popupElement && render(<Popup />, popupElement)
+if (panelElement) render(<Panel />, panelElement)
+if (optionsElement) render(<Options />, optionsElement)
+if (popupElement) render(<Popup />, popupElement)

src/Bridge.ts

@@ -67,7 +67,6 @@ export const Bridge = new (class {
   }
 
   init() {
-    // eslint-disable-next-line no-console
     console.log('Setting up bridge...')
 
     if (!browser || !browser.devtools) return
@@ -119,7 +118,6 @@ Bridge.register('sync-subscriptions', (message: Message<any>) => {
 })
 
 Bridge.register('stats', (message: Message<any>) => {
-  // eslint-disable-next-line no-console
   console.log(message.data)
 
   PanelStore.setGitCommitHash(message.data.gitCommitHash)

src/Browser/Background.ts

@@ -12,24 +12,23 @@ const Cache = new Map<number, string[]>()
 
 const connections: Connection = new Map()
 
-self.connections = connections
+globalThis.connections = connections
 
 const panelListener = () => {
   browser.runtime.onConnect.addListener(port => {
     console.debug('runtime.onConnect', port)
 
     port.onMessage.addListener(request => {
-      // eslint-disable-next-line no-console
       console.debug('port.onMessage', request)
 
       if (request.name === 'init') {
         connections.set(request.tabId, port)
 
         // Pick things from cache and send it to the panel.
         if (Cache.has(request.tabId)) {
-          Cache.get(request.tabId).forEach(message => {
+          for (const message of Cache.get(request.tabId)) {
             port.postMessage(message)
-          })
+          }
         }
 
         port.onDisconnect.addListener(() => {
@@ -61,7 +60,7 @@ action.onClicked.addListener(e => {
     .create({
       url: 'http://cloud.meteor.com/?utm_source=chrome_extension&utm_medium=extension&utm_campaign=meteor_devtools_evolved',
     })
-    // eslint-disable-next-line no-console
+
     .catch(console.error)
 })
 
@@ -70,10 +69,8 @@ const handleConsole = (
   { data: { type, message } }: Message<{ type: ConsoleType; message: string }>,
 ) => {
   if (type in console) {
-    // eslint-disable-next-line no-console
     console[type](`[${tabId}]`, message)
   } else {
-    // eslint-disable-next-line no-console
     console.warn('Wrong console type.')
   }
 }
@@ -88,7 +85,6 @@ const contentListener = () => {
 
       // The message event has to from the panel to the content and then through here.
       if (request?.eventType === 'cache:clear') {
-        // eslint-disable-next-line no-console
         console.debug('clear cache')
         Cache.delete(tabId)
         return
@@ -102,7 +98,7 @@ const contentListener = () => {
       if (Cache.has(tabId)) {
         const entry = Cache.get(tabId)
 
-        if (entry.length >= 10000) {
+        if (entry.length >= 10_000) {
           entry.shift()
         }
 
@@ -132,19 +128,17 @@ const tabListener = () => {
   /**
    * @issue https://stackoverflow.com/a/73836810/10567157
    */
-  chrome.runtime.onMessage.addListener(function (
-    request,
-    sender,
-    sendResponse,
-  ) {
-    sendResponse({ foo: true })
+  chrome.runtime.onMessage.addListener(
+    function (request, sender, sendResponse) {
+      sendResponse({ foo: true })
 
-    if (request.source !== 'meteor-devtools-evolved') return true
+      if (request.source !== 'meteor-devtools-evolved') return true
 
-    tabEvent[request.eventType]?.(request)
+      tabEvent[request.eventType]?.(request)
 
-    return true
-  })
+      return true
+    },
+  )
 }
 
 panelListener()

src/Browser/Content.ts

@@ -2,7 +2,7 @@ import browser from 'webextension-polyfill'
 
 const messageHandler = (event: MessageEvent) => {
   // Only accept messages from same frame
-  if (event.source !== window) return
+  if (event.source !== globalThis) return
 
   // Only accept messages that we know are ours
   if (event.data.source !== 'meteor-devtools-evolved') return

src/Browser/Inject.ts

@@ -7,8 +7,8 @@ import { MeteorAdapter } from '@/Injectors/MeteorAdapter'
 
 const isFrame = (function () {
   try {
-    return window.self !== window.top
-  } catch (e) {
+    return globalThis.self !== window.top
+  } catch {
     return true
   }
 })()
@@ -41,7 +41,7 @@ const getStackTrace = (stackTraceLimit: number) => {
 
   try {
     Error.stackTraceLimit = stackTraceLimit
-    const error = new Error()
+    const error = new Error('Stack trace')
 
     if (!error.stack) return []
 
@@ -66,7 +66,7 @@ const getStackTrace = (stackTraceLimit: number) => {
 export const sendLogMessage = (message: DDPLog) => {
   const stackTrace = getStackTrace(15)
 
-  if (stackTrace && stackTrace.length) {
+  if (stackTrace && stackTrace.length > 0) {
     stackTrace.splice(0, 2)
   }
 
@@ -108,17 +108,19 @@ export const Registry: IRegistry = {
   },
 
   run(message: IMessagePayload<any>) {
-    this.subscriptions.forEach(
-      ({ eventType, handler }) =>
+    for (const { eventType, handler } of this.subscriptions) {
+      if (
         message.source === 'meteor-devtools-evolved' &&
-        eventType === message.eventType &&
-        handler(message),
-    )
+        eventType === message.eventType
+      ) {
+        handler(message)
+      }
+    }
   },
 }
 
 export function injectAll() {
-  if (!window.__meteor_devtools_evolved) {
+  if (!globalThis.__meteor_devtools_evolved) {
     if (isFrame) return false
 
     warning(
@@ -133,14 +135,14 @@ export function injectAll() {
     function inject() {
       --attempts
 
-      if (typeof Meteor === 'object' && !window.__meteor_devtools_evolved) {
-        window.__meteor_devtools_evolved = true
+      if (typeof Meteor === 'object' && !globalThis.__meteor_devtools_evolved) {
+        globalThis.__meteor_devtools_evolved = true
 
         DDPInjector()
         MinimongoInjector()
         MeteorAdapter()
 
-        window.__meteor_devtools_evolved_receiveMessage =
+        globalThis.__meteor_devtools_evolved_receiveMessage =
           Registry.run.bind(Registry)
 
         warning(`Initialized. Attempts: ${100 - attempts}.`)
@@ -149,7 +151,7 @@ export function injectAll() {
       if (attempts === 0) {
         clearInterval(interval)
 
-        if (!window.Meteor) {
+        if (!globalThis.Meteor) {
           warning(
             isFrame
               ? `Unable to find Meteor on iframe "${location.href}"`
@@ -161,7 +163,7 @@ export function injectAll() {
 
     inject()
 
-    interval = window.setInterval(inject, 10)
+    interval = globalThis.setInterval(inject, 10)
   }
 }
 

src/Components/TabBar.tsx

@@ -117,8 +117,8 @@ export const TabBar: FunctionComponent<Props> = ({ tabs, menu, onChange }) => {
           key={tab.key}
           onClick={() => {
             setKey(tab.key)
-            onChange && onChange(tab.key)
-            tab.handler && tab.handler()
+            if (onChange) onChange(tab.key)
+            if (tab.handler) tab.handler()
           }}
           className={classnames('mde-tab', {
             active: activeKey === tab.key,

src/Database/PanelDatabase.ts

@@ -45,14 +45,12 @@ class Database extends Dexie {
   }
 
   async saveSettings(settings: ISettings) {
-    if (await this.data.get('settings')) {
-      return this.data.update('settings', settings)
-    } else {
-      return this.data.add({
-        id: 'settings',
-        ...settings,
-      })
-    }
+    return (await this.data.get('settings'))
+      ? this.data.update('settings', settings)
+      : this.data.add({
+          id: 'settings',
+          ...settings,
+        })
   }
 }
 

src/Injectors/MeteorAdapter.ts

@@ -27,7 +27,7 @@ export const MeteorAdapter = () => {
 
   const prototype = Mongo.Collection.prototype
 
-  Object.entries(prototype).forEach(([key, val]) => {
+  for (const [key, val] of Object.entries(prototype)) {
     if (
       ['find', 'findOne', 'insert', 'update', 'upsert', 'remove'].includes(
         key,
@@ -50,5 +50,5 @@ export const MeteorAdapter = () => {
         return result
       }
     }
-  })
+  }
 }

src/Injectors/MinimongoInjector.ts

@@ -3,7 +3,7 @@ import { Registry, sendMessage } from '@/Browser/Inject'
 import throttle from 'lodash.throttle'
 
 function cloneDeep(obj: any) {
-  return JSON.parse(JSON.stringify(obj))
+  return structuredClone(obj)
 }
 
 function isArray(obj: any) {
@@ -17,7 +17,7 @@ const cleanup = (object: any) => {
 
   if (!clonedObject) return clonedObject
 
-  Object.keys(clonedObject).forEach((key: string) => {
+  for (const key of Object.keys(clonedObject)) {
     if (!clonedObject[key]) {
       return
     }
@@ -49,17 +49,15 @@ const cleanup = (object: any) => {
 
       clonedObject[key] = cleanup(clonedObject[key])
     }
-  })
+  }
 
   return clonedObject
 }
 
 const getDocs = (collection: any) => {
-  if (collection._docs._map instanceof Map) {
-    return collection._docs._map?.values() || []
-  } else {
-    return Object.values(collection._docs._map || {})
-  }
+  return collection._docs._map instanceof Map
+    ? collection._docs._map?.values() || []
+    : Object.values(collection._docs._map || {})
 }
 
 const getCollections = () => {
@@ -72,12 +70,11 @@ const getCollections = () => {
     return
   }
 
-  const data = Object.values(collections).reduce(
-    (acc: object, collection: any) =>
-      Object.assign(acc, {
-        [collection.name]: Array.from(getDocs(collection)).map(cleanup),
-      }),
-    {},
+  const data = Object.fromEntries(
+    Object.values(collections).map((collection: any) => [
+      collection.name,
+      [...getDocs(collection)].map(item => cleanup(item)),
+    ]),
   )
 
   sendMessage('minimongo-get-collections', data as any)