fixup! refactor(compiler): support passing content to specific foreign component props

Author: leonsenft

packages/compiler/src/template/pipeline/src/ingest.ts

@@ -313,34 +313,24 @@ function ingestElement(unit: ViewCompilationUnit, element: t.Element): void {
     }
 
     for (const block of contentBlocks) {
-      const blockView = unit.job.allocateView(unit.xref);
-      ingestNodes(blockView, block.children);
-
-      unit.create.push(
-        ir.createContentOp(
-          id,
-          block.name,
-          blockView.xref,
-          block.name.charAt(0).toUpperCase() + block.name.slice(1),
-          block.startSourceSpan,
-          block.sourceSpan,
-        ),
+      ingestForeignContentBlock(
+        unit,
+        id,
+        block.name,
+        block.children,
+        block.startSourceSpan,
+        block.sourceSpan,
       );
     }
 
     if (childNodes.length > 0) {
-      const childView = unit.job.allocateView(unit.xref);
-      ingestNodes(childView, childNodes);
-
-      unit.create.push(
-        ir.createContentOp(
-          id,
-          'children',
-          childView.xref,
-          'Children',
-          element.startSourceSpan,
-          element.sourceSpan,
-        ),
+      ingestForeignContentBlock(
+        unit,
+        id,
+        'children',
+        childNodes,
+        element.startSourceSpan,
+        element.sourceSpan,
       );
     }
 
@@ -395,6 +385,32 @@ function ingestElement(unit: ViewCompilationUnit, element: t.Element): void {
   }
 }
 
+/**
+ * Ingest a content block for a foreign component.
+ */
+function ingestForeignContentBlock(
+  unit: ViewCompilationUnit,
+  targetId: ir.XrefId,
+  propertyName: string,
+  childNodes: t.Node[],
+  startSourceSpan: ParseSourceSpan,
+  sourceSpan: ParseSourceSpan,
+): void {
+  const childView = unit.job.allocateView(unit.xref);
+  ingestNodes(childView, childNodes);
+
+  unit.create.push(
+    ir.createContentOp(
+      targetId,
+      propertyName,
+      childView.xref,
+      propertyName.charAt(0).toUpperCase + propertyName.slice(1),
+      startSourceSpan,
+      sourceSpan,
+    ),
+  );
+}
+
 /**
  * Ingest an `ng-template` node from the AST into the given `ViewCompilation`.
  */