feat(leaves): New list component.#35
Merged
Merged
Conversation
Owner
|
Thanks for opening the PR @Lattay! ✨ – I'd really appreciate if you can record a demo for this new component in an example so its obvious what it does and we can feature it in the examples index page. To record you can install VHS and run |
Contributor
Author
|
Ok, so... now that I have updated to riot 0.0.8 and stuff, my example is broken in a very weird way. It makes me thinh about a race condition somewhere because it is pretty random:
Investigating that now... |
46ab3fc to
98888b7
Compare
The list can be filtered, and elements can be selected.
Contributor
Author
Owner
|
Hi @Lattay! This looks fantastic ✨ – thanks a million for contributing! Merging it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi,
I'd like to get some feedback on this proposal of list component.
What is implemented:
What is not implemented:
Also, I couldn't get the dev version of minttea to build (independantly of my modifications, something wrong with the versions of Riot and libc and other I think), so I only tested the component and the example with commit 87c8072 (that is release 0.0.2).
This is the main reason why I consider this to be WIP.