Skip to content

Commit bbfaf98

Browse files
Merge branch 'fixErrorInDecisions-847' into 'stable-3_3_0'
Corrige problema da opção para publicar dataset em decisões editoriais - 3.3.0 See merge request softwares-pkp/plugins_ojs/dataverse!213
2 parents d8b231b + c46368c commit bbfaf98

3 files changed

Lines changed: 24 additions & 4 deletions

File tree

classes/dispatchers/DataverseEventsDispatcher.inc.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,10 @@ public function addDatasetPublishNoticeInEditorAction(string $hookName, array $p
234234
$form = &$params[0];
235235
$output = &$params[1];
236236

237+
if ($form->getDecision() != SUBMISSION_EDITOR_DECISION_ACCEPT) {
238+
return $output;
239+
}
240+
237241
$request = Application::get()->getRequest();
238242
$context = $request->getContext();
239243
$templateMgr = TemplateManager::getManager($request);

cypress/tests/Test05_EditorDecision.spec.js

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ describe('Research data publishing in editor decision', function () {
165165
cy.waitDatasetTabLoading('datasetTab');
166166
cy.get('#datasetTab-button .pkpBadge').contains('2');
167167
});
168-
it('Check research data is published in editor decision', function () {
168+
it('Check research data can be published in article acceptance', function () {
169169
cy.login('dbarnes', null, 'publicknowledge');
170170
cy.findSubmission('active', submission.title);
171171

@@ -181,7 +181,23 @@ describe('Research data publishing in editor decision', function () {
181181
cy.get('input[name="shouldPublishResearchData"][value="1"]').should('not.be.checked');
182182
cy.get('input[name="shouldPublishResearchData"][value="0"]').should('not.be.checked');
183183

184-
cy.get('input[name="shouldPublishResearchData"][value="1"]').click();
184+
cy.get('input[name="shouldPublishResearchData"][value="0"]').click();
185185
cy.get('button:contains("Record Editorial Decision")').click();
186+
cy.wait(1000);
187+
188+
cy.get('#workflow-button').click();
189+
cy.get('li.pkp_workflow_editorial.initiated').within(() => {
190+
cy.contains('Copyediting');
191+
});
192+
});
193+
it('Dataset publish prompt does not appear when sending to production', function () {
194+
cy.login('dbarnes', null, 'publicknowledge');
195+
cy.findSubmission('active', submission.title);
196+
197+
cy.get('ul.pkp_workflow_decisions:visible a:contains("Send To Production")', { timeout: 30000 }).click();
198+
cy.get('button:contains("Next:")').click();
199+
200+
cy.get('#researchDataNotice').should('not.exist');
201+
cy.get('#researchDataPublishChoice').should('not.exist');
186202
});
187203
});

version.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
<version>
1414
<application>dataverse</application>
1515
<type>plugins.generic</type>
16-
<release>2.8.6.0</release>
17-
<date>2025-10-22</date>
16+
<release>2.8.6.1</release>
17+
<date>2025-10-29</date>
1818
<lazy-load>1</lazy-load>
1919
<class>DataversePlugin</class>
2020
</version>

0 commit comments

Comments
 (0)