Merge branch 'fixSingleFileScenario330-909' into 'stable-3_3_0'

JhonathanLepidus · JhonathanLepidus · commit d9be4126d3ac · 2026-05-18T16:31:09.000-04:00
Corrige cenário onde apenas arquivo README é enviado - 3.3.0

See merge request softwares-pkp/plugins_ojs/dataverse!229
diff --git a/api/v1/datasets/DatasetHandler.inc.php b/api/v1/datasets/DatasetHandler.inc.php
@@ -211,6 +211,10 @@ public function addDataset($slimRequest, $response, $args)
             return $response->withStatus(404)->withJsonError('plugins.generic.dataverse.error.readmeFileRequired');
         }
 
+        if (count($draftDatasetFiles) == 1) {
+            return $response->withStatus(404)->withJsonError('plugins.generic.dataverse.error.notSolelyReadmeFile');
+        }
+
         $submission = Services::get('submission')->get($submissionId);
 
         import('plugins.generic.dataverse.classes.factories.SubmissionDatasetFactory');
@@ -227,7 +231,7 @@ public function addDataset($slimRequest, $response, $args)
             $depositInfo = $datasetService->deposit($submission, $dataset);
             if ($depositInfo['status'] != 'Success') {
                 return $response->withStatus(403)->withJsonError(
-                    $depositInfo['message'].'.author',
+                    $depositInfo['message'] . '.author',
                     $depositInfo['messageParams']
                 );
             }
diff --git a/classes/dispatchers/DraftDatasetFilesDispatcher.inc.php b/classes/dispatchers/DraftDatasetFilesDispatcher.inc.php
@@ -126,5 +126,10 @@ private function validateResearchDataReadme(SubmissionSubmitStep2Form $form): vo
             $form->addError('dataverseStep2ValidationError', __("plugins.generic.dataverse.error.readmeFileRequired"));
             $form->addErrorField('dataverseStep2ValidationError');
         }
+
+        if (count($draftDatasetFiles) == 1) {
+            $form->addError('dataverseStep2ValidationError', __("plugins.generic.dataverse.error.notSolelyReadmeFile"));
+            $form->addErrorField('dataverseStep2ValidationError');
+        }
     }
 }
diff --git a/cypress/tests/Test03_ResearchDataDeposit.spec.js b/cypress/tests/Test03_ResearchDataDeposit.spec.js
@@ -68,7 +68,7 @@ describe('Research data deposit', function () {
 		cy.get('button').contains('Finish Submission').click();
 		cy.wait(1000);
 		cy.get('button.pkpModalConfirmButton').click();
-		cy.get('div:contains("To submit research data, it is necessary to send at least one file.")');
+		cy.get('div:contains("To submit research data, it is necessary to send at least one file, accompanied by a README file")');
 		cy.get('div:contains("Please ensure that you have chosen and submitted research data files in step 2 of the submission.")');
 
 		cy.get('#submitTabs a:contains("2. Upload Submission")').click();
diff --git a/locale/en_US/locale.po b/locale/en_US/locale.po
@@ -109,7 +109,7 @@ msgid  "plugins.generic.dataverse.log.sendDatasetDeleteEmail"
 msgstr "Email sent to {$email} notifying the deletion of research data."
 
 msgid "plugins.generic.dataverse.error.researchDataRequired"
-msgstr "To submit research data, it is necessary to send at least one file.<br>"
+msgstr "To submit research data, it is necessary to send at least one file, accompanied by a README file.<br>"
 "Please ensure that you have chosen and submitted research data files in step 2 of the submission."
 
 msgid "plugins.generic.dataverse.error.datasetSubjectRequired"
@@ -119,6 +119,9 @@ msgstr "The subject of the research data is required.<br>"
 msgid "plugins.generic.dataverse.error.readmeFileRequired"
 msgstr "It is mandatory to send a README file, in PDF or TXT format, to accompany the research data files"
 
+msgid "plugins.generic.dataverse.error.notSolelyReadmeFile"
+msgstr "The research data cannot consist solely of the README file"
+
 msgid "plugins.generic.dataverse.error.getFailed"
 msgstr "Error getting research data to Dataverse: {$error}"
 
diff --git a/locale/es_ES/locale.po b/locale/es_ES/locale.po
@@ -112,7 +112,7 @@ msgid  "plugins.generic.dataverse.log.sendDatasetDeleteEmail"
 msgstr "Correo electrónico enviado a {$email} para notificar la eliminación de los datos de investigación."
 
 msgid "plugins.generic.dataverse.error.researchDataRequired"
-msgstr "Para enviar datos de investigación, es necesario enviar al menos un archivo.<br>"
+msgstr "Para enviar datos de investigación, es necesario enviar al menos un archivo, acompañado de un archivo README.<br>"
 "Asegúrate de haber seleccionado y enviado archivos de datos de investigación en el paso 2 del envío."
 
 msgid "plugins.generic.dataverse.error.datasetSubjectRequired"
@@ -122,6 +122,9 @@ msgstr "El asunto de los datos de investigación es obligatorio.<br>"
 msgid "plugins.generic.dataverse.error.readmeFileRequired"
 msgstr "Es obligatorio enviar un archivo README, en formato PDF o TXT, que acompañe a los archivos de datos de la investigación"
 
+msgid "plugins.generic.dataverse.error.notSolelyReadmeFile"
+msgstr "Los datos de investigación no pueden consistir únicamente en el archivo README"
+
 msgid "plugins.generic.dataverse.error.getFailed"
 msgstr "Erro al obtener datos de investigación en Dataverse: {$error}"
 
diff --git a/locale/pt_BR/locale.po b/locale/pt_BR/locale.po
@@ -112,7 +112,7 @@ msgid  "plugins.generic.dataverse.log.sendDatasetDeleteEmail"
 msgstr "Email enviado para {$email} notificando a exclusão dos dados de pesquisa"
 
 msgid "plugins.generic.dataverse.error.researchDataRequired"
-msgstr "Para submeter dados de pesquisa é necessário enviar pelo menos um arquivo.<br>"
+msgstr "Para submeter dados de pesquisa é necessário enviar pelo menos um arquivo, acompanhado de um arquivo README.<br>"
 "Certifique-se que você escolheu e enviou arquivos de dados de pesquisa no passo 2 da submissão."
 
 msgid "plugins.generic.dataverse.error.datasetSubjectRequired"
@@ -122,6 +122,9 @@ msgstr "O assunto dos dados de pesquisa é obrigatório.<br>"
 msgid "plugins.generic.dataverse.error.readmeFileRequired"
 msgstr "É obrigatório o envio de um arquivo README, em formato PDF ou TXT, que acompanhe os arquivos de dados de pesquisa"
 
+msgid "plugins.generic.dataverse.error.notSolelyReadmeFile"
+msgstr "Os dados da pesquisa não podem ser constituídos apenas pelo arquivo README"
+
 msgid "plugins.generic.dataverse.error.getFailed"
 msgstr "Erro ao obter dados de pesquisa no Dataverse: {$error}"
 
diff --git a/upgrade.xml b/upgrade.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE install SYSTEM "../../../lib/pkp/dtd/install.dtd">
 
-<install version="2.8.9.2">
+<install version="2.8.9.3">
     <migration
         class="plugins.generic.dataverse.classes.migration.APITokenEncryptionMigration"
     />
diff --git a/version.xml b/version.xml
@@ -13,8 +13,8 @@
 <version>
 	<application>dataverse</application>
 	<type>plugins.generic</type>
-	<release>2.8.9.2</release>
-	<date>2026-05-14</date>
+	<release>2.8.9.3</release>
+	<date>2026-05-18</date>
 	<lazy-load>1</lazy-load>
 	<class>DataversePlugin</class>
 </version>

Original file line number	Diff line number	Diff line change
`@@ -126,5 +126,10 @@ private function validateResearchDataReadme(SubmissionSubmitStep2Form $form): vo`
`126`	`126`	`$form->addError('dataverseStep2ValidationError', __("plugins.generic.dataverse.error.readmeFileRequired"));`
`127`	`127`	`$form->addErrorField('dataverseStep2ValidationError');`
`128`	`128`	`}`
	`129`	`+`
	`130`	`+ if (count($draftDatasetFiles) == 1) {`
	`131`	`+ $form->addError('dataverseStep2ValidationError', __("plugins.generic.dataverse.error.notSolelyReadmeFile"));`
	`132`	`+ $form->addErrorField('dataverseStep2ValidationError');`
	`133`	`+ }`
`129`	`134`	`}`
`130`	`135`	`}`