Fix bug in deletion threshold selection value.

issue: documentacao-e-tarefas/desenvolvimento_e_infra#646

Signed-off-by: iudi <iudi@lepidus.com.br>
Signed-off-by: jhon <jhon@lepidus.com.br>

Author: iudizm

form/DeleteIncompleteSubmissionsSettingsForm.inc.php

@@ -38,7 +38,8 @@ public function fetch($request, $template = null, $display = false)
         $templateMgr = TemplateManager::getManager($request);
         $templateMgr->assign('pluginName', $this->plugin->getName());
         $templateMgr->assign('applicationName', Application::get()->getName());
-        $templateMgr->assign('thresholdValues', range(15, 60));
+        $templateMgr->assign('thresholdValues', range(0, 60));
+        $templateMgr->assign('defaultThreshold', 15);
 
         return parent::fetch($request, $template, $display);
     }
@@ -50,13 +51,12 @@ public function execute(...$functionArgs)
 
         $deletionThreshold = $this->getData('deletionThreshold');
 
-        $numDeleted = $this->deleteIncompleteSubmissions($deletionThreshold);
+        $this->deleteIncompleteSubmissions($deletionThreshold);
         parent::execute(...$functionArgs);
     }
 
-    private function deleteIncompleteSubmissions(int $deletionThreshold): int
+    private function deleteIncompleteSubmissions(int $deletionThreshold): void
     {
-        $deleted = 0;
         $submissionService = Services::get('submission');
         $submissions = $submissionService->getMany([
             'contextId' => $this->contextId, 'isIncomplete' => true, 'daysInactive' => $deletionThreshold
@@ -65,11 +65,9 @@ private function deleteIncompleteSubmissions(int $deletionThreshold): int
         foreach ($submissions as $submission) {
             try {
                 $submissionService->delete($submission);
-                $deleted++;
             } catch (\Throwable $th) {
                 error_log('The submission  ' . $submission->getId() . ' was not deleted. Reason:' . $th->getMessage());
             }
         }
-        return $deleted;
     }
 }

templates/settingsForm.tpl

@@ -16,7 +16,7 @@
         {fbvFormArea id="deleteIncompleteSubmissionsSettingsFormArea"}
 
         {fbvFormSection list="true"}
-        {fbvElement type="select" name="deletionThreshold" id="deletionThreshold" from=$thresholdValues label="plugins.generic.deleteIncompleteSubmissions.deletion.threshold" translate="0" size=$fbvStyles.size.SMALL}
+        {fbvElement type="select" name="deletionThreshold" id="deletionThreshold" from=$thresholdValues selected=$defaultThreshold label="plugins.generic.deleteIncompleteSubmissions.deletion.threshold" translate="0" size=$fbvStyles.size.SMALL}
 
         {fbvFormButtons id="deleteIncompleteSubmissionsSettingsFormSubmit" submitText="common.delete"}