Skip to content

Commit 0c1fb39

Browse files
Merge branch 'removeIncompleteSubmissions340-858' into 'main'
Retrieving of submissions only considers completed ones See merge request softwares-pkp/plugins_ojs/relatorioscielo!38
2 parents 6db816c + a7a72c0 commit 0c1fb39

3 files changed

Lines changed: 15 additions & 10 deletions

File tree

classes/ScieloSubmissionsDAO.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,17 @@ class ScieloSubmissionsDAO extends DAO
2424

2525
public function getSubmissions($locale, $contextId, $sectionsIds, $submissionDateInterval, $finalDecisionDateInterval)
2626
{
27-
$query = DB::table('submissions')
28-
->join('publications', 'submissions.current_publication_id', '=', 'publications.publication_id')
29-
->where('submissions.context_id', $contextId)
30-
->whereNotNull('submissions.date_submitted')
31-
->whereIn('publications.section_id', $sectionsIds)
32-
->select('submissions.submission_id');
27+
$query = DB::table('submissions AS s')
28+
->join('publications AS p', 's.current_publication_id', '=', 'p.publication_id')
29+
->where('s.context_id', $contextId)
30+
->where('s.submission_progress', '=', '')
31+
->whereNotNull('s.date_submitted')
32+
->whereIn('p.section_id', $sectionsIds)
33+
->select('s.submission_id');
3334

3435
if (!is_null($submissionDateInterval)) {
35-
$query = $query->where('submissions.date_submitted', '>=', $submissionDateInterval->getBeginningDate())
36-
->where('submissions.date_submitted', '<=', $submissionDateInterval->getEndDate());
36+
$query = $query->where('s.date_submitted', '>=', $submissionDateInterval->getBeginningDate())
37+
->where('s.date_submitted', '<=', $submissionDateInterval->getEndDate());
3738
}
3839

3940
$result = $query->get();

tests/ScieloSubmissionsReportFactoryTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,11 @@ private function createSubmission($dateSubmitted = null, $finalDecisions = []):
9393

9494
if (!is_null($dateSubmitted)) {
9595
$submission->setData('dateSubmitted', $dateSubmitted);
96+
$submission->setData('submissionProgress', '');
97+
} else {
98+
$submission->setData('submissionProgress', 'start');
9699
}
100+
97101
$submissionId = Repo::submission()->dao->insert($submission);
98102

99103
if (!empty($finalDecisions)) {

version.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<version>
55
<application>scieloSubmissionsReport</application>
66
<type>plugins.reports</type>
7-
<release>3.0.5.1</release>
8-
<date>2025-10-06</date>
7+
<release>3.0.5.2</release>
8+
<date>2025-11-24</date>
99
<lazy-load>1</lazy-load>
1010
<class>ScieloSubmissionsReportPlugin</class>
1111
</version>

0 commit comments

Comments
 (0)