Skip to content

Commit 56de1cf

Browse files
Treats case where submission has no titles
Issue: documentacao-e-tarefas/scielo#789 Signed-off-by: Jhon <jhon@lepidus.com.br>
1 parent ba7d87c commit 56de1cf

6 files changed

Lines changed: 18 additions & 2 deletions

File tree

classes/ScieloSubmission.inc.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,10 @@ public function getId(): int
5656

5757
public function getTitle(): string
5858
{
59-
return preg_replace('/\s+/', ' ', $this->title);
59+
$this->title = preg_replace('/\s+/', ' ', $this->title);
60+
$messageNoTitles = __("plugins.reports.scieloSubmissionsReport.warning.noTitles");
61+
62+
return fillEmptyFields($this->title, $messageNoTitles);
6063
}
6164

6265
public function getSubmitter(): string

classes/ScieloSubmissionsDAO.inc.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@ public function getPublicationTitle($publicationId, $locale, $submissionLocale)
8484
$titles[$locale] = $title;
8585
}
8686

87+
if (empty($titles)) {
88+
return '';
89+
}
90+
8791
if (array_key_exists($locale, $titles)) {
8892
return $titles[$locale];
8993
}

locale/en_US/locale.po

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ msgstr ""
5858
"The report generation proccesss can take a few minutes, depending on the parameters selected and the number of submissions present in the system. "
5959
"In case it lasts longer, please contact the support team."
6060

61+
msgid "plugins.reports.scieloSubmissionsReport.warning.noTitles"
62+
msgstr "No titles"
63+
6164
msgid "plugins.reports.scieloSubmissionsReport.warning.noResponsibles"
6265
msgstr "No responsibles assigned"
6366

locale/es_ES/locale.po

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ msgstr ""
5858
"El proceso de generación de informes puede tardar unos minutos, según los parámetros seleccionados y la cantidad de envíos presentes en el sistema. "
5959
"Si la demora dura más, comuníquese con el equipo de soporte."
6060

61+
msgid "plugins.reports.scieloSubmissionsReport.warning.noTitles"
62+
msgstr "Sin títulos"
63+
6164
msgid "plugins.reports.scieloSubmissionsReport.warning.noResponsibles"
6265
msgstr "Sin responsables designados"
6366

locale/pt_BR/locale.po

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ msgstr ""
5858
"O processo de geração do relatório pode demorar poucos minutos, dependendo do parâmetros selecionados e do número de submissões presentes no sistema. "
5959
"Caso a demora se estenda por mais tempo, contate a equipe de suporte."
6060

61+
msgid "plugins.reports.scieloSubmissionsReport.warning.noTitles"
62+
msgstr "Sem títulos"
63+
6164
msgid "plugins.reports.scieloSubmissionsReport.warning.noResponsibles"
6265
msgstr "Sem responsáveis designados"
6366

tests/ScieloArticleFactoryTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ public function testArticleCreationWhenItHasNoTitles(): void
226226
$scieloArticle = $articleFactory->createSubmission($this->submissionId, $this->locale);
227227

228228
$this->assertTrue($scieloArticle instanceof ScieloArticle);
229-
$this->assertEquals("", $scieloArticle->getTitle());
229+
$this->assertEquals(__('plugins.reports.scieloSubmissionsReport.warning.noTitles'), $scieloArticle->getTitle());
230230
}
231231

232232
/**

0 commit comments

Comments
 (0)