update valuetask

Author: pomianowski

src/ReflectionEventing.Demo.Wpf/ViewModels/MainWindowViewModel.cs

@@ -21,11 +21,11 @@ public partial class MainWindowViewModel(IEventBus eventBus, ILogger<MainWindowV
     private int _queueCount;
 
     /// <inheritdoc />
-    public async ValueTask ConsumeAsync(ITickedEvent payload, CancellationToken cancellationToken)
+    public ValueTask ConsumeAsync(ITickedEvent payload, CancellationToken cancellationToken)
     {
         int tickValue = payload.Value;
 
-        await DispatchAsync(
+        return DispatchAsync(
             () =>
             {
                 CurrentTick = tickValue;
@@ -35,11 +35,11 @@ await DispatchAsync(
     }
 
     /// <inheritdoc />
-    public async ValueTask ConsumeAsync(OtherEvent payload, CancellationToken cancellationToken)
+    public ValueTask ConsumeAsync(OtherEvent payload, CancellationToken cancellationToken)
     {
         logger.LogInformation("Received {Event} event.", nameof(OtherEvent));
 
-        await ValueTask.CompletedTask;
+        return default;
     }
 
     /// <inheritdoc />

src/ReflectionEventing/EventBus.cs

@@ -160,7 +160,12 @@ CancellationToken cancellationToken
                 cancellationToken
             );
 
-            if (!task.IsCompletedSuccessfully)
+            if (task.IsCompletedSuccessfully)
+            {
+                // Ensure pooled IValueTaskSource is properly returned
+                task.GetAwaiter().GetResult();
+            }
+            else
             {
                 asyncTasks ??= new List<ValueTask>(consumers.Count);
                 asyncTasks.Add(task);