Flyout now shows a drop shadow#1716
Open
chucker wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
fixes #1708
The current Flyout looks a little naked:
This is also inconsistent with WinUI 3, which wraps it in a drop shadow:
What is the new behavior?
This wraps Flyout with a drop shadow similar to how #1472 did it in other areas (such as context menu):
Other information
The positioning isn't quite right. Horizontally, I think it's supposed to be concentric with the control below (but that would be for a separate PR), and vertically, it has too much of an offset. If someone has an idea how to shove it closer to the control below, that'd be great.