Actually validate grant code#287
Open
prateekmadhikar wants to merge 1 commit intolepture:masterfrom
prateekmadhikar:validate-grant-code
Open
Actually validate grant code#287prateekmadhikar wants to merge 1 commit intolepture:masterfrom prateekmadhikar:validate-grant-code
prateekmadhikar wants to merge 1 commit intolepture:masterfrom
prateekmadhikar:validate-grant-code
Conversation
|
You should probably check if there are any appropriate tests that should be added here (I believe that's why the coverage is decreasing). You can probably add a nosetest for validating a correct/incorrect short-lived token. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #286.
Checks that the code from the request matches the code retrieved from
_grantgetter