Simplify & improve bold+italic#8
Open
anjiro wants to merge 2 commits into
Open
Conversation
Works for *bold _italic_ more bold* etc
Owner
|
I'm not sure this works as you think. At least, on my end, this no longer allows bold italics at all... |
Owner
|
That is, at the current master, |
Contributor
Author
|
Hm, how strange… it worked briefly then stopped. I’ll investigate further. |
Owner
|
You added the |
Contributor
Author
|
Yes, you’re right—I had to do some file shuffling to get the repository in the right place to do the PR and lost those lines. Try now? |
lervag
added a commit
that referenced
this pull request
Nov 12, 2021
Owner
|
Thanks, works now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized my earlier PR #7 didn’t work for
*bold with _embedded italic_ text*and_italics with *bold* text inside_. In the course of fixing that I simplified the code.