Skip to content

Bump jquery from 3.2.1 to 3.5.0 - #14

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/jquery-3.5.0
Open

Bump jquery from 3.2.1 to 3.5.0#14
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/jquery-3.5.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Apr 29, 2020

Copy link
Copy Markdown

Bumps jquery from 3.2.1 to 3.5.0.

Commits
  • 7a0a850 3.5.0
  • 8570a08 Release: Update AUTHORS.txt
  • da3dd85 Ajax: Do not execute scripts for unsuccessful HTTP responses
  • 065143c Ajax: Overwrite s.contentType with content-type header value, if any
  • 1a4f10d Tests: Blacklist one focusin test in IE
  • 9e15d6b Event: Use only one focusin/out handler per matching window & document
  • 966a709 Manipulation: Skip the select wrapper for <option> outside of IE 9
  • 1d61fd9 Manipulation: Make jQuery.htmlPrefilter an identity function
  • 04bf577 Selector: Update Sizzle from 2.3.4 to 2.3.5
  • 7506c9c Build: Resolve Travis config warnings
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by mgol, a new releaser for jquery since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [jquery](https://github.com/jquery/jquery) from 3.2.1 to 3.5.0.
- [Release notes](https://github.com/jquery/jquery/releases)
- [Commits](jquery/jquery@3.2.1...3.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Apr 29, 2020
@agatheblues

Copy link
Copy Markdown

Hello @letranloc ! We are using your package, and it raised a security issue because of the jquery dependency (should be >= 3.5.0).

How likely is it to have this PR merged and a new release out with this fix? Would you have time for that? 🏒

Thanks!

@tarjei tarjei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the patch seems to add a lot more than just the jquery dependency. Would it be possible to provide a patch that only contains a bump of jquery?

Comment thread yarn.lock
dependencies:
match-at "^0.1.0"

katex@^0.9.0-alpha1:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the patch adds a bunch of duplicate dependencies can they be cleaned out or placed in a separate patch?

@tarjei

tarjei commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

@agatheblues see comment.

Question: Which parts of this library do you use? I've been considering to split it up to make it a bit more maintainable, but that requires that I know which parts people are interested int.

@agatheblues

Copy link
Copy Markdown

Hello! Thanks for the quick reply 🤸‍♀️

Question: Which parts of this library do you use? I've been considering to split it up to make it a bit more maintainable, but that requires that I know which parts people are interested int.

I'm not sure if I got the question right, but I think we just use the InsertButton component in our toolbar

Hi, the patch seems to add a lot more than just the jquery dependency. Would it be possible to provide a patch that only contains a bump of jquery?

Should I provide a PR? Or is that something you would do?

@tarjei

tarjei commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

I would love it if you provided a patch!

The reason I'm asking is because Jquery++ is used for the MathInput mobile component which I'm considering to remove to make this component leaner.

@agatheblues

Copy link
Copy Markdown

I would love it if you provided a patch!

The reason I'm asking is because Jquery++ is used for the MathInput mobile component which I'm considering to remove to make this component leaner.

Ah I see! Well, we're not using the MathInput part of the library 🎉 I will see if I can draft a quick patch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants