-
Notifications
You must be signed in to change notification settings - Fork 12
Expand file tree
/
Copy pathdependency_error_test.go
More file actions
194 lines (172 loc) · 5.63 KB
/
Copy pathdependency_error_test.go
File metadata and controls
194 lines (172 loc) · 5.63 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
package executor
import (
"bytes"
"fmt"
"os"
"os/exec"
"strings"
"syscall"
"testing"
)
func TestPrependToChain(t *testing.T) {
t.Run("new error creates single-element chain", func(t *testing.T) {
orig := fmt.Errorf("something failed")
result := prependToChain("lint", orig)
depErr, ok := result.(*DependencyError)
if !ok {
t.Fatalf("expected *DependencyError, got %T", result)
}
if len(depErr.Chain) != 1 || depErr.Chain[0] != "lint" {
t.Errorf("expected chain [lint], got %v", depErr.Chain)
}
if depErr.Err != orig {
t.Errorf("expected original error to be preserved")
}
})
t.Run("existing DependencyError gets name prepended", func(t *testing.T) {
base := &DependencyError{
Chain: []string{"lint"},
Err: fmt.Errorf("orig"),
}
result := prependToChain("build", base)
depErr, ok := result.(*DependencyError)
if !ok {
t.Fatalf("expected *DependencyError, got %T", result)
}
if len(depErr.Chain) != 2 || depErr.Chain[0] != "build" || depErr.Chain[1] != "lint" {
t.Errorf("expected chain [build lint], got %v", depErr.Chain)
}
})
t.Run("three deep chain accumulates correctly", func(t *testing.T) {
err := fmt.Errorf("exit 1")
err = prependToChain("lint", err)
err = prependToChain("build", err)
err = prependToChain("deploy", err)
depErr, ok := err.(*DependencyError)
if !ok {
t.Fatalf("expected *DependencyError, got %T", err)
}
want := []string{"deploy", "build", "lint"}
if len(depErr.Chain) != 3 {
t.Fatalf("expected chain length 3, got %d: %v", len(depErr.Chain), depErr.Chain)
}
for i, name := range want {
if depErr.Chain[i] != name {
t.Errorf("chain[%d]: want %q, got %q", i, name, depErr.Chain[i])
}
}
})
}
func TestDependencyErrorExitCode(t *testing.T) {
t.Run("returns 1 when ExecuteError wraps non-ExitError", func(t *testing.T) {
execErr := &ExecuteError{err: fmt.Errorf("failed")}
depErr := &DependencyError{Chain: []string{"lint"}, Err: execErr}
if depErr.ExitCode() != 1 {
t.Errorf("expected exit code 1, got %d", depErr.ExitCode())
}
})
t.Run("returns 1 for non-ExecuteError", func(t *testing.T) {
depErr := &DependencyError{Chain: []string{"lint"}, Err: fmt.Errorf("plain error")}
if depErr.ExitCode() != 1 {
t.Errorf("expected default exit code 1, got %d", depErr.ExitCode())
}
})
t.Run("propagates real exit code from exec.ExitError", func(t *testing.T) {
cmd := exec.Command("bash", "-c", "exit 2")
runErr := cmd.Run()
if runErr == nil {
t.Fatal("expected command to fail")
}
execErr := &ExecuteError{err: runErr}
depErr := &DependencyError{Chain: []string{"lint"}, Err: execErr}
if depErr.ExitCode() != 2 {
t.Errorf("expected exit code 2, got %d", depErr.ExitCode())
}
})
}
func TestDependencyErrorError(t *testing.T) {
inner := fmt.Errorf("inner error message")
depErr := &DependencyError{Chain: []string{"lint"}, Err: inner}
if depErr.Error() != "inner error message" {
t.Errorf("expected Error() to delegate to Err, got %q", depErr.Error())
}
}
func TestDependencyErrorFailureMessage(t *testing.T) {
t.Run("returns root cause for execute errors", func(t *testing.T) {
depErr := &DependencyError{
Chain: []string{"lint"},
Err: &ExecuteError{err: fmt.Errorf("failed to run command 'lint': %w", fmt.Errorf("exit status 1"))},
}
if got := depErr.FailureMessage(); got != "exit status 1" {
t.Fatalf("expected root cause message, got %q", got)
}
})
t.Run("keeps non execute errors intact", func(t *testing.T) {
depErr := &DependencyError{
Chain: []string{"lint"},
Err: fmt.Errorf("failed to calculate checksum for command 'lint': missing file"),
}
if got := depErr.FailureMessage(); got != "failed to calculate checksum for command 'lint': missing file" {
t.Fatalf("expected original message, got %q", got)
}
})
t.Run("keeps path context for execute errors", func(t *testing.T) {
depErr := &DependencyError{
Chain: []string{"lint"},
Err: &ExecuteError{
err: fmt.Errorf(
"failed to run command 'lint': %w",
&os.PathError{Op: "chdir", Path: "/tmp/missing", Err: syscall.ENOENT},
),
},
}
if got := depErr.FailureMessage(); got != "chdir /tmp/missing: no such file or directory" {
t.Fatalf("expected path-aware message, got %q", got)
}
})
}
func TestPrintDependencyTree(t *testing.T) {
t.Run("single node", func(t *testing.T) {
depErr := &DependencyError{Chain: []string{"lint"}, Err: fmt.Errorf("fail")}
var buf bytes.Buffer
PrintDependencyTree(depErr, &buf)
out := buf.String()
lines := strings.Split(strings.TrimRight(out, "\n"), "\n")
if len(lines) != 2 {
t.Fatalf("expected 2 lines, got %d: %v", len(lines), lines)
}
want := []string{
dependencyTreeHeader,
dependencyTreeIndent + "lint" + dependencyTreeIndent + "<-- failed here",
}
for i := range want {
if lines[i] != want[i] {
t.Errorf("line %d: want %q, got %q", i, want[i], lines[i])
}
}
})
t.Run("three nodes with correct indentation", func(t *testing.T) {
depErr := &DependencyError{
Chain: []string{"deploy", "build", "lint"},
Err: fmt.Errorf("fail"),
}
var buf bytes.Buffer
PrintDependencyTree(depErr, &buf)
lines := strings.Split(strings.TrimRight(buf.String(), "\n"), "\n")
if len(lines) != 4 {
t.Fatalf("expected 4 lines, got %d: %v", len(lines), lines)
}
want := []string{
dependencyTreeHeader,
dependencyTreeIndent + "deploy",
dependencyTreeIndent + dependencyTreeJoint + "build",
strings.Repeat(dependencyTreeIndent, 2) + dependencyTreeJoint + "lint" +
dependencyTreeIndent + "<-- failed here",
}
for i := range want {
if lines[i] != want[i] {
t.Errorf("line %d: want %q, got %q", i, want[i], lines[i])
}
}
})
}