Enhance logging formatter tests

Author: kindermax

internal/logging/formatter.go

@@ -21,7 +21,7 @@ type Formatter struct{}
 // Format implements the log.Formatter interface.
 func (f *Formatter) Format(entry *log.Entry) ([]byte, error) {
 	buff := &bytes.Buffer{}
-	parts := []string{color.BlueString("lets:")}
+	parts := []string{formatPrefix(entry)}
 
 	if data := writeData(entry.Data); data != "" {
 		parts = append(parts, data)
@@ -35,8 +35,16 @@ func (f *Formatter) Format(entry *log.Entry) ([]byte, error) {
 	return buff.Bytes(), nil
 }
 
+func formatPrefix(entry *log.Entry) string {
+	if entry.Level == log.DebugLevel {
+		return color.BlueString("lets:")
+	}
+
+	return "lets:"
+}
+
 func formatMessage(entry *log.Entry) string {
-	if entry.Level >= log.DebugLevel {
+	if entry.Level == log.DebugLevel {
 		return color.BlueString(entry.Message)
 	}
 

internal/logging/log_test.go

@@ -52,32 +52,20 @@ func TestLoggingToStd(t *testing.T) {
 	})
 }
 
-func TestFormatterColorsVerboseMessages(t *testing.T) {
+func TestFormatterColorsDebugMessages(t *testing.T) {
 	setNoColorForTest(t, false)
 
-	tests := []struct {
-		name  string
-		level log.Level
-	}{
-		{name: "debug", level: log.DebugLevel},
-		{name: "trace", level: log.TraceLevel},
+	line, err := (&Formatter{}).Format(&log.Entry{
+		Level:   log.DebugLevel,
+		Message: "debug message",
+	})
+	if err != nil {
+		t.Fatalf("Format() error = %v", err)
 	}
 
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			line, err := (&Formatter{}).Format(&log.Entry{
-				Level:   tt.level,
-				Message: "debug message",
-			})
-			if err != nil {
-				t.Fatalf("Format() error = %v", err)
-			}
-
-			expected := color.BlueString("lets:") + " " + color.BlueString("debug message") + "\n"
-			if string(line) != expected {
-				t.Fatalf("unexpected debug line: %q", string(line))
-			}
-		})
+	expected := color.BlueString("lets:") + " " + color.BlueString("debug message") + "\n"
+	if string(line) != expected {
+		t.Fatalf("unexpected debug line: %q", string(line))
 	}
 }
 
@@ -120,6 +108,14 @@ func TestFormatterFormatsLevelsAndFields(t *testing.T) {
 			},
 			fields: []string{"alpha=one", "beta=two"},
 		},
+		{
+			name: "trace_no_data",
+			entry: &log.Entry{
+				Level:   log.TraceLevel,
+				Message: "trace message",
+				Data:    log.Fields{},
+			},
+		},
 	}
 
 	for _, tt := range tests {