check remote mixin content type when downloading

Author: kindermax

config/config/config.go

@@ -282,8 +282,7 @@ func (c *Config) readMixins(mixins []*Mixin) error {
 
 	for _, mixin := range mixins {
 		if err := c.readMixin(mixin); err != nil {
-			// TODO: check if error is correct, concise and for humans
-			return err
+			return fmt.Errorf("failed to read remote mixin config '%s': %w", mixin.Remote.URL, err)
 		}
 	}
 

config/config/mixin.go

@@ -12,9 +12,18 @@ import (
 	"strings"
 	"time"
 
+	"github.com/lets-cli/lets/set"
 	"github.com/lets-cli/lets/util"
 )
 
+var allowedContentTypes = set.NewSet(
+	"text/plain",
+	"text/yaml",
+	"text/x-yaml",
+	"application/yaml",
+	"application/x-yaml",
+)
+
 type Mixins []*Mixin
 
 type Mixin struct {
@@ -110,6 +119,11 @@ func (rm *RemoteMixin) download() ([]byte, error) {
 		return nil, fmt.Errorf("network error: %s", resp.Status)
 	}
 
+	contentType := resp.Header.Get("Content-Type")
+	if !allowedContentTypes.Contains(contentType) {
+		return nil, fmt.Errorf("unsupported content type: %s", contentType)
+	}
+
 	data, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response: %w", err)

docs/docs/ide_support.md

@@ -62,35 +62,18 @@ vim.filetype.add({
 })
 ```
 
-2. In your `neovim/nvim-lspconfig` servers configuration:
+2. Define `lets_ls` lsp config
 
-In order for `nvim-lspconfig` to recognize `lets lsp` we must define config for `lets_ls` (lets_ls is just a conventional name because we are not officially added to `neovim/nvim-lspconfig`)
+Requires `neovim >= 0.11.2`
 
 ```lua
-require("lspconfig.configs").lets_ls = {
-  default_config = {
-    cmd = { 
-      "lets self lsp",
-    },
-    filetypes = { "yaml.lets" },
-    root_dir = util.root_pattern("lets.yaml"),
-    settings = {},
-  },
+vim.lsp.config.lets_ls = {
+  cmd = { "lets", "self", "lsp" },
+  filetypes = { "yaml.lets" },
+  root_markers = { "lets.yaml" },
 }
-```
-
-3. And then enable lets_ls in then servers section:
 
-```lua
-return {
-  "neovim/nvim-lspconfig",
-  opts = {
-    servers = {
-      lets_ls = {},
-      pyright = {},  -- pyright here just as hint to where we should add lets_ls
-    },
-  },
-}
+vim.lsp.enable("lets_ls")
 ```
 
 ### JSON Schema