Skip to content

Commit b7a8483

Browse files
committed
Add joint to root command in failure tree
1 parent fe970fc commit b7a8483

3 files changed

Lines changed: 10 additions & 16 deletions

File tree

internal/executor/dependency_error.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,8 @@ func (e *DependencyError) TreeMessage() string {
5050

5151
for i, name := range e.Chain {
5252
builder.WriteByte('\n')
53-
indentLevel := i
54-
if indentLevel == 0 {
55-
indentLevel = 1
56-
}
57-
builder.WriteString(strings.Repeat(dependencyTreeIndent, indentLevel))
58-
if i > 0 {
59-
builder.WriteString(dependencyTreeJoint)
60-
}
53+
builder.WriteString(strings.Repeat(dependencyTreeIndent, i+1))
54+
builder.WriteString(dependencyTreeJoint)
6155
builder.WriteString(name)
6256

6357
if i == len(e.Chain)-1 {

internal/executor/dependency_error_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func TestPrintDependencyTree(t *testing.T) {
155155
}
156156
want := []string{
157157
dependencyTreeHeader,
158-
dependencyTreeIndent + "lint" + dependencyTreeIndent + "<-- failed here",
158+
dependencyTreeIndent + dependencyTreeJoint + "lint" + dependencyTreeIndent + "<-- failed here",
159159
}
160160

161161
for i := range want {
@@ -179,9 +179,9 @@ func TestPrintDependencyTree(t *testing.T) {
179179
}
180180
want := []string{
181181
dependencyTreeHeader,
182-
dependencyTreeIndent + "deploy",
183-
dependencyTreeIndent + dependencyTreeJoint + "build",
184-
strings.Repeat(dependencyTreeIndent, 2) + dependencyTreeJoint + "lint" +
182+
dependencyTreeIndent + dependencyTreeJoint + "deploy",
183+
strings.Repeat(dependencyTreeIndent, 2) + dependencyTreeJoint + "build",
184+
strings.Repeat(dependencyTreeIndent, 3) + dependencyTreeJoint + "lint" +
185185
dependencyTreeIndent + "<-- failed here",
186186
}
187187

tests/dependency_failure_tree.bats

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ setup() {
1010
run env NO_COLOR=1 lets deploy
1111
assert_failure
1212
assert_line --index 0 "lets: command failed:"
13-
assert_line --index 1 " deploy"
14-
assert_line --index 2 " └─ build"
15-
assert_line --index 3 " └─ lint <-- failed here"
13+
assert_line --index 1 " └─ deploy"
14+
assert_line --index 2 " └─ build"
15+
assert_line --index 3 " └─ lint <-- failed here"
1616
assert_line --index 4 "lets: exit status 1"
1717
}
1818

1919
@test "dependency_failure_tree: single node when no depends" {
2020
run env NO_COLOR=1 lets lint
2121
assert_failure
2222
assert_line --index 0 "lets: command failed:"
23-
assert_line --index 1 " lint <-- failed here"
23+
assert_line --index 1 " └─ lint <-- failed here"
2424
assert_line --index 2 "lets: exit status 1"
2525
}

0 commit comments

Comments
 (0)