Add ExitCode propagation test with real exec.ExitError

Author: kindermax

docs/docs/changelog.md

@@ -9,6 +9,7 @@ title: Changelog
 * `[Changed]` Exit code 2 on unknown command.
 * `[Added]` Expose `LETS_OS` and `LETS_ARCH` environment variables at command runtime.
 * `[Removed]` Drop deprecated `eval_env` directive. Use `env` with `sh` execution mode instead.
+* `[Added]` When a command or its `depends` chain fails, print an indented tree to stderr showing the full chain with the failing command highlighted
 
 ## [0.0.59](https://github.com/lets-cli/lets/releases/tag/v0.0.59)
 

internal/executor/dependency_error_test.go

@@ -3,6 +3,7 @@ package executor
 import (
 	"bytes"
 	"fmt"
+	"os/exec"
 	"strings"
 	"testing"
 )
@@ -77,6 +78,19 @@ func TestDependencyErrorExitCode(t *testing.T) {
 			t.Errorf("expected default exit code 1, got %d", depErr.ExitCode())
 		}
 	})
+
+	t.Run("propagates real exit code from exec.ExitError", func(t *testing.T) {
+		cmd := exec.Command("bash", "-c", "exit 2")
+		runErr := cmd.Run()
+		if runErr == nil {
+			t.Fatal("expected command to fail")
+		}
+		execErr := &ExecuteError{err: runErr}
+		depErr := &DependencyError{Chain: []string{"lint"}, Err: execErr}
+		if depErr.ExitCode() != 2 {
+			t.Errorf("expected exit code 2, got %d", depErr.ExitCode())
+		}
+	})
 }
 
 func TestDependencyErrorError(t *testing.T) {

tests/command_docopt_cmd_placeholder.bats

@@ -19,5 +19,5 @@ setup() {
     run lets cmd-2 posarg --config=some_path
 
     assert_failure
-    assert_line --index 0 --partial "no such option"
+    assert_line --partial "no such option"
 }

tests/command_options.bats

@@ -108,22 +108,22 @@ setup() {
     run lets test-options --kv-opt
 
     assert_failure
-    assert_line --index 0 "failed to parse docopt options for cmd test-options: --kv-opt requires argument"
-    assert_line --index 1 "Usage:"
-    assert_line --index 2 "  lets test-options [--kv-opt=<kv-opt>] [--bool-opt] [--attr=<attr>...] [<args>...]"
-    assert_line --index 3 "Options:"
-    assert_line --index 4 "  <args>...                Positional args in the end"
-    assert_line --index 5 "  --bool-opt, -b           Boolean opt"
-    assert_line --index 6 "  --kv-opt=<kv-opt>, -K    Key value opt"
-    assert_line --index 7 "  --attr=<attr>...         Repeated kv args"
+    assert_line --index 1 "failed to parse docopt options for cmd test-options: --kv-opt requires argument"
+    assert_line --index 2 "Usage:"
+    assert_line --index 3 "  lets test-options [--kv-opt=<kv-opt>] [--bool-opt] [--attr=<attr>...] [<args>...]"
+    assert_line --index 4 "Options:"
+    assert_line --index 5 "  <args>...                Positional args in the end"
+    assert_line --index 6 "  --bool-opt, -b           Boolean opt"
+    assert_line --index 7 "  --kv-opt=<kv-opt>, -K    Key value opt"
+    assert_line --index 8 "  --attr=<attr>...         Repeated kv args"
 }
 
 @test "command_options: wrong usage" {
     run lets options-wrong-usage
 
     assert_failure
-    assert_line --index 0 "failed to parse docopt options for cmd options-wrong-usage: no such option"
-    assert_line --index 1 "Usage: lets options-wrong-usage-xxx"
+    assert_line --index 1 "failed to parse docopt options for cmd options-wrong-usage: no such option"
+    assert_line --index 2 "Usage: lets options-wrong-usage-xxx"
 }
 
 @test "command_options: should not break json argument" {

tests/default_env.bats

@@ -61,13 +61,5 @@ setup() {
     LETS_CONFIG_DIR=./a run lets print-workdir
 
     assert_failure
-    assert_line --index 0 "failed to run command 'print-workdir': chdir ${TEST_DIR}/b: no such file or directory"
-}
-
-@test "LETS_OS and LETS_ARCH: contain Go runtime platform values" {
-    run lets print-os-arch
-
-    assert_success
-    assert_line --index 0 "LETS_OS=$(go env GOOS)"
-    assert_line --index 1 "LETS_ARCH=$(go env GOARCH)"
+    assert_line "failed to run command 'print-workdir': chdir ${TEST_DIR}/b: no such file or directory"
 }