restored comment, fixed imports, remove unused crypto/rand, and reverted vendor changes

Author: mkhandker19

linter/makesigner.go

@@ -5,7 +5,6 @@ package linter
 import (
 	"crypto"
 	"crypto/ecdsa"
-	"crypto/rand"
 	"crypto/rsa"
 	"fmt"
 )
@@ -15,12 +14,12 @@ func makeSigner(realSigner crypto.Signer) (crypto.Signer, error) {
 	var err error
 	switch k := realSigner.Public().(type) {
 	case *rsa.PublicKey:
-		lintSigner, err = rsa.GenerateKey(rand.Reader, k.Size()*8)
+		lintSigner, err = rsa.GenerateKey(nil, k.Size()*8)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create RSA lint signer: %w", err)
 		}
 	case *ecdsa.PublicKey:
-		lintSigner, err = ecdsa.GenerateKey(k.Curve, rand.Reader)
+		lintSigner, err = ecdsa.GenerateKey(k.Curve, nil)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create ECDSA lint signer: %w", err)
 		}

linter/makesigner_go127.go

@@ -6,7 +6,6 @@ import (
 	"crypto"
 	"crypto/ecdsa"
 	"crypto/mldsa"
-	"crypto/rand"
 	"crypto/rsa"
 	"fmt"
 )
@@ -19,12 +18,12 @@ func makeSigner(realSigner crypto.Signer) (crypto.Signer, error) {
 	var err error
 	switch k := realSigner.Public().(type) {
 	case *rsa.PublicKey:
-		lintSigner, err = rsa.GenerateKey(rand.Reader, k.Size()*8)
+		lintSigner, err = rsa.GenerateKey(nil, k.Size()*8)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create RSA lint signer: %w", err)
 		}
 	case *ecdsa.PublicKey:
-		lintSigner, err = ecdsa.GenerateKey(k.Curve, rand.Reader)
+		lintSigner, err = ecdsa.GenerateKey(k.Curve, nil)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create ECDSA lint signer: %w", err)
 		}

test/integration/issuance_test.go

@@ -5,7 +5,6 @@ package integration
 import (
 	"crypto/ecdsa"
 	"crypto/elliptic"
-	"crypto/rand"
 	"crypto/x509"
 	"crypto/x509/pkix"
 	"fmt"
@@ -184,7 +183,7 @@ func TestIssuanceMTC(t *testing.T) {
 		t.Fatalf("creating acme client: %s", err)
 	}
 
-	key, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
+	key, err := ecdsa.GenerateKey(elliptic.P256(), nil)
 	if err != nil {
 		t.Fatalf("generating keypair: %s", err)
 	}