integration: make TestRevocation non-parallel

Author: jsha

test/integration/revocation_test.go

@@ -388,43 +388,39 @@ func TestRevocation(t *testing.T) {
 	for _, kind := range []certKind{precert, finalcert} {
 		for _, reason := range []revocation.Reason{revocation.Unspecified, revocation.KeyCompromise, revocation.Superseded} {
 			for _, method := range []authMethod{byAccount, byAuth, byKey, byAdmin} {
-				wg.Add(1)
-				go func() {
-					defer wg.Done()
-					cert := issueAndRevoke(testCase{
-						method: method,
-						reason: reason,
-						kind:   kind,
-						// We do not expect any of these revocation requests to error.
-						// The ones done byAccount will succeed as requested, but will not
-						// result in the key being blocked for future issuance.
-						// The ones done byAuth will succeed, but will be overwritten to have
-						// reason code 5 (cessationOfOperation).
-						// The ones done byKey will succeed, but will be overwritten to have
-						// reason code 1 (keyCompromise), and will block the key.
-					})
-
-					// If the request was made by demonstrating control over the
-					// names, the reason should be overwritten to CessationOfOperation (5),
-					// and if the request was made by key, then the reason should be set to
-					// KeyCompromise (1).
-					expectedReason := reason
-					switch method {
-					case byAuth:
-						expectedReason = revocation.CessationOfOperation
-					case byKey:
-						expectedReason = revocation.KeyCompromise
-					default:
-					}
+				cert := issueAndRevoke(testCase{
+					method: method,
+					reason: reason,
+					kind:   kind,
+					// We do not expect any of these revocation requests to error.
+					// The ones done byAccount will succeed as requested, but will not
+					// result in the key being blocked for future issuance.
+					// The ones done byAuth will succeed, but will be overwritten to have
+					// reason code 5 (cessationOfOperation).
+					// The ones done byKey will succeed, but will be overwritten to have
+					// reason code 1 (keyCompromise), and will block the key.
+				})
+
+				// If the request was made by demonstrating control over the
+				// names, the reason should be overwritten to CessationOfOperation (5),
+				// and if the request was made by key, then the reason should be set to
+				// KeyCompromise (1).
+				expectedReason := reason
+				switch method {
+				case byAuth:
+					expectedReason = revocation.CessationOfOperation
+				case byKey:
+					expectedReason = revocation.KeyCompromise
+				default:
+				}
 
-					check := func(t *testing.T, allCRLs map[string][]*x509.RevocationList) {
-						checkRevoked(t, allCRLs, cert, expectedReason)
-					}
+				check := func(t *testing.T, allCRLs map[string][]*x509.RevocationList) {
+					checkRevoked(t, allCRLs, cert, expectedReason)
+				}
 
-					rcMu.Lock()
-					revocationChecks = append(revocationChecks, check)
-					rcMu.Unlock()
-				}()
+				rcMu.Lock()
+				revocationChecks = append(revocationChecks, check)
+				rcMu.Unlock()
 			}
 		}
 	}