publisher: Log serials in hex (#8844)

beautifulentropy · web-flow · commit 92a55b7a0ae1 · 2026-07-06T15:24:44.000-07:00
blog.Serial documents that its argument should be the hex-encoded form, and every other call site uses core.SerialToString. This one logged the big.Int decimal form, which matches nothing else in the system when searching or joining on serial. This PR was generated as part of an audit of #8606 using Claude Fable 5.
diff --git a/publisher/publisher.go b/publisher/publisher.go
@@ -265,7 +265,7 @@ func (pub *Impl) SubmitToSingleCTWithResult(ctx context.Context, req *pubpb.Requ
 			body = string(rspErr.Body)
 		}
 		pub.log.Info(ctx, "Failed to submit certificate to CT log",
-			blog.Serial(cert.SerialNumber.String()),
+			blog.Serial(core.SerialToString(cert.SerialNumber)),
 			slog.String("issuer", cert.Issuer.CommonName),
 			slog.String("log", ctLog.uri),
 			slog.String("body", body),

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ func (pub Impl) SubmitToSingleCTWithResult(ctx context.Context, req pubpb.Requ`
`265`	`265`	`body = string(rspErr.Body)`
`266`	`266`	`}`
`267`	`267`	`pub.log.Info(ctx, "Failed to submit certificate to CT log",`
`268`		`- blog.Serial(cert.SerialNumber.String()),`
	`268`	`+ blog.Serial(core.SerialToString(cert.SerialNumber)),`
`269`	`269`	`slog.String("issuer", cert.Issuer.CommonName),`
`270`	`270`	`slog.String("log", ctLog.uri),`
`271`	`271`	`slog.String("body", body),`