crl-updater: Fix lookback period for GetRevokedCertsByShard#8071
Closed
aarongable wants to merge 1 commit intomainfrom
Closed
crl-updater: Fix lookback period for GetRevokedCertsByShard#8071aarongable wants to merge 1 commit intomainfrom
aarongable wants to merge 1 commit intomainfrom
Conversation
Contributor
Contributor
Author
|
Obviated by the change above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of the lookback period is so that entries are not removed from a CRL until well after they have expired, to ensure we comply with RFC 5280, Section 3.3, which says "An entry MUST NOT be removed from the CRL until it appears on one regularly scheduled CRL issued beyond the revoked certificate's validity period."
Setting the expiresAfter time to be in the future means that certificates will be omitted from the query before they expire, rather than after. Change the sign of the lookbackPeriod so that the expiresAfter timestamp is in the past.