WFE: Return err instead of prob from parseRevocation helper#8076
Merged
aarongable merged 1 commit intomainfrom Mar 25, 2025
Merged
WFE: Return err instead of prob from parseRevocation helper#8076aarongable merged 1 commit intomainfrom
aarongable merged 1 commit intomainfrom
Conversation
aarongable
requested review from
beautifulentropy,
jprenken and
jsha
and removed request for
jsha
jprenken
approved these changes
Mar 21, 2025
beautifulentropy
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the wfe.parseRevocation function to return
errorinstead ofprobs.ProblemDetails. This slightly changes some of our user-facing error messages to be more complete and verbose, thanks to how ProblemDetailsForError works.This is a building block towards making the probs.ProblemDetails type not implement the Error interface, and only be used when rendering errors to the user (i.e. not within Boulder logic itself).
Part of #4980