Move some python revocation tests to Go#8082
Merged
aarongable merged 9 commits intomainfrom Mar 28, 2025
Merged
Conversation
…ert_unspecified_byAccount
…ert_keyCompromise_byAccount
beautifulentropy
approved these changes
Mar 27, 2025
Member
beautifulentropy
left a comment
beautifulentropy
left a comment
There was a problem hiding this comment.
Nice, this change looks great.
Contributor
Author
|
Test-only, merging on one review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete several python revocation integration tests whose functionality is already replicated by the go revocation integration tests. Add support for revoking via admin-revoker to TestRevocation, and use that to replace several more python tests.
The go versions of these tests use CRLs, rather than OCSP, to confirm the revocation status of the certs in question. This is fine because the purpose of these tests is to ensure that we handle revocation requests correctly in general, not specifically via OCSP.
Part of #8059