Conversation
aarongable
reviewed
Mar 6, 2026
This replaces the health check inside `test/entrypoint.sh`. Advantage: if bvitess exits outright during health checking, `docker compose` can report that more clearly than `test/entrypoint.sh` can, and can also terminte the run of the `boulder` container early, rather than waiting for the health check to timeout. We can apply the same transformation to the other health checks if we like this one.
jsha
force-pushed
the
healthcheck-vitess
branch
from
d75b9fc to
21d81e0
Compare
aarongable
approved these changes
Mar 17, 2026
Contributor
Author
|
Test-only, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the health check inside
test/entrypoint.sh. Advantage: if bvitess exits outright during health checking,docker composecan report that more clearly thantest/entrypoint.shcan, and can also terminte the run of thebouldercontainer early, rather than waiting for the health check to timeout.We can apply the same transformation to the other health checks if we like this one.