Conversation
Instead of logging each check, log final failures. Also, if a service is slow to become healthy, log that.
aarongable
approved these changes
Mar 11, 2026
Contributor
Author
|
Test-only, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of logging each check, log final failures. Also, if a service is slow to become healthy, log that.
Right now, the
boulder-ra-sct-providerinstances take about 5s to become healthy in our CI runs, and health-checker spams the logs a lot during that period. We should improve the startup time, but this is a quick fix to reduce the log spam.