From 9368d7b60b29905357ca9d41d13078442a2f9b20 Mon Sep 17 00:00:00 2001 From: Jacob Hoffman-Andrews Date: Wed, 11 Mar 2026 11:08:54 -0700 Subject: [PATCH] test: make health-checker quieter Instead of logging each check, log final failures. Also, if a service is slow to become healthy, log that. --- test/health-checker/main.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/health-checker/main.go b/test/health-checker/main.go index dca1c01e7d5..16c46e64622 100644 --- a/test/health-checker/main.go +++ b/test/health-checker/main.go @@ -59,7 +59,8 @@ func main() { ctx, cancel := context.WithTimeout(context.Background(), 10*c.GRPC.Timeout.Duration) defer cancel() - for { + start := time.Now() + for i := 1; ; i++ { select { case <-ticker.C: _, hostOverride, err := c.GRPC.MakeTargetAndHostOverride() @@ -84,8 +85,11 @@ func main() { if strings.Contains(err.Error(), "authentication handshake failed") { cmd.Fail(fmt.Sprintf("health checking %s (%s): %s\n", c.GRPC.HostOverride, *serverAddr, err)) } - fmt.Fprintf(os.Stderr, "health checking %s (%s): %s\n", c.GRPC.HostOverride, *serverAddr, err) } else if resp.Status == healthpb.HealthCheckResponse_SERVING { + elapsed := time.Since(start) + if elapsed > 1*time.Second { + fmt.Printf("service %s is healthy after %s with %d tries\n", *serverAddr, elapsed, i) + } return } else { cmd.Fail(fmt.Sprintf("service %s failed health check with status %s", *serverAddr, resp.Status))