Skip to content

test: make health-checker quieter #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsha merged 1 commit into from
Mar 11, 2026
+6 −2
Merged

test: make health-checker quieter #8671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/health-checker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ func main() {
ctx, cancel := context.WithTimeout(context.Background(), 10*c.GRPC.Timeout.Duration)
defer cancel()

for {
start := time.Now()
for i := 1; ; i++ {
select {
case <-ticker.C:
_, hostOverride, err := c.GRPC.MakeTargetAndHostOverride()
Expand All @@ -84,8 +85,11 @@ func main() {
if strings.Contains(err.Error(), "authentication handshake failed") {
cmd.Fail(fmt.Sprintf("health checking %s (%s): %s\n", c.GRPC.HostOverride, *serverAddr, err))
}
fmt.Fprintf(os.Stderr, "health checking %s (%s): %s\n", c.GRPC.HostOverride, *serverAddr, err)
} else if resp.Status == healthpb.HealthCheckResponse_SERVING {
elapsed := time.Since(start)
if elapsed > 1*time.Second {
fmt.Printf("service %s is healthy after %s with %d tries\n", *serverAddr, elapsed, i)
}
return
} else {
cmd.Fail(fmt.Sprintf("service %s failed health check with status %s", *serverAddr, resp.Status))
Expand Down
Loading