va: Add experimental VA for testing Hickory#8688
Merged
beautifulentropy merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
beautifulentropy
force-pushed
the
experimental-va
branch
from
8fe2948 to
e5de061
Compare
beautifulentropy
force-pushed
the
experimental-va
branch
from
e5de061 to
5ada869
Compare
jsha
requested changes
Mar 26, 2026
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
I really like the approach of instantiating another VA implementation in-memory. It achieves a nice clean result.
| "primaryPassed": primaryPassed, | ||
| "primaryResult": primary, | ||
| "experimentPassed": experimentPassed, | ||
| "experimentResult": experimentResult, |
Contributor
There was a problem hiding this comment.
Here we'll be JSON-marshaling an object of type remoteResult. I think that's fine, since json uses reflection to look inside, and it'll be a protobuf inside, and those marshal well. Mind posting an example of the output to verify?
Member
Author
There was a problem hiding this comment.
Here's what that looks like:
[INFO: [AUDIT] Primary VA disagreed with experimental VA JSON={"experimentPassed":false,"experimentResult":{"problem":{"problemType":"dns","detail":"unexpected LookupTXT call on test fake","httpStatus":400},"perspective":"Experimental"},"operation":"dcv","primaryPassed":true,"primaryResult":{"records":[{"hostname":"good-dns01.com","resolverAddrs":["txtFakeDNS"]}],"perspective":"example perspective 8fVnUg"}}]
8b5f111 to
c9f3e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an optional parallel VA instance that repeats the primary VA's DCV and CAA checks using an alternative DNS resolver. This enables side-by-side comparison of DNS resolution behavior (e.g. Unbound vs Hickory) without affecting validation decisions.
Validation shadowing is performed according to a configurable sampling rate (0.0 to 1.0), giving us the ability to control what percentage of our traffic will also hit experimental resolvers and keep our log volumes reasonable.
Fixes #8677