Conversation
We send the user-agent header through grpc as metadata. grpc-go by default validates metadata values as printable ASCII. We can override that assumption by naming our header with "-bin". For a transition period, send and accept both header names. After deploy, we'll remove the old one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We send the user-agent header through grpc as metadata. grpc-go by default validates metadata values as printable ASCII. We can override that assumption by naming our header with "-bin".
For a transition period, send and accept both header names. After deploy, we'll remove the old one.
Also, trim the User-Agent to a max size before logging, and add a unittest for the max size.