wfe2: omit order expires when unset#8778
Closed
eyupcanakman wants to merge 1 commit into
Closed
Conversation
orderJSON.Expires was a bare time.Time with no omitempty, so an order without an expiry serialized expires as a placeholder timestamp instead of omitting it. Make it a *time.Time with omitempty and set it only when present. Addresses letsencrypt#8711.
Contributor
|
Hi @eyupcanakman ! Welcome to Boulder, and thanks for the contribution. As noted in #8711, in Boulder an order expires is always set. I'd rather not add code to handle the case where it's unset, for a couple of reasons:
What we really want is a check that Expires is never zero, erroring if so. We already have that in the places in wfe.go where we receive an error. So I consider that item under #8711 invalid. I'll comment to clarify. Sorry you spent your time on an issue that turned out to be invalid! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orderJSON.Expireswas a baretime.Timewith noomitempty, set fromorder.Expires.AsTime(). An order with no expiry has a zero value there, so the response serialized"expires":"1970-01-01T00:00:00Z"instead of leaving the field out. The fix switches it to a*time.Timewithomitemptyand sets it only when the order has an expiry, the same wayIsAnyNilOrZeroguards other optional fields in wfe2.Addresses the order.expires item in #8711.