ra: call MTCA when profile indicates MTC#8781
Conversation
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
1 similar comment
|
@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
| vac := vapb.NewVAClient(vaConn) | ||
| caaClient := vapb.NewCAAClient(vaConn) | ||
|
|
||
| profileToMTCA := make(map[string]mtcapb.MTCAClient) |
There was a problem hiding this comment.
In the future there may be multiple profiles that all map to the same MTCA, which would necessitate rewriting how the loop below populates this map, but this is definitely good enough for now.
| func New(issuer *issuance.Issuer) *mtca { | ||
| return &mtca{ | ||
| issuer: issuer, | ||
| logID: issuer.Cert.Subject.String(), |
There was a problem hiding this comment.
If this is truly the logID, and not the caID, then shouldn't it be fmt.Sprintf("%s.0.%d", issuer.Cert.Subject.String(), logGeneration)?
There was a problem hiding this comment.
Good call. I split this up a bit: mtcaID, logNumber, and a helper function called .mtcLogID().
Since we're going to be using profiles to decide whether an issuance uses MTC, remove the isMTC field from the orders table in boulder_sa_next.
aarongable
requested review from
a team and
ezekiel
and removed request for
a team
3 participants
Since we're going to be using profiles to decide whether an issuance uses MTC, remove the isMTC field from the orders table in boulder_sa_next.