Skip to content

Remove sa.FQDNSetExists dead code #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ezekiel wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove sa.FQDNSetExists dead code #8888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f85bace
Remove sa.FQDNSetExists dead code
ezekiel Jul 17, 2026
bba0c77
Merge remote-tracking branch 'origin/main' into ezekiel/remove-fqdnse…
ezekiel Jul 28, 2026
a1fde7c
Move checkFQDNSetExists next to its single caller.
ezekiel Jul 28, 2026
121f809
Merge branch 'main' into ezekiel/remove-fqdnsetexists-dead
aarongable Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions mocks/sa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,6 @@ func (sa *StorageAuthorityReadOnly) FQDNSetTimestampsForWindow(_ context.Context
return &sapb.Timestamps{}, nil
}

// FQDNSetExists is a mock
func (sa *StorageAuthorityReadOnly) FQDNSetExists(_ context.Context, _ *sapb.FQDNSetExistsRequest, _ ...grpc.CallOption) (*sapb.Exists, error) {
return &sapb.Exists{Exists: false}, nil
}

// GetOrder is a mock
func (sa *StorageAuthorityReadOnly) GetOrder(_ context.Context, req *sapb.OrderRequest, _ ...grpc.CallOption) (*corepb.Order, error) {
switch req.Id {
Expand Down
Loading
Loading