ci: use zizmor and remediate findings - #346
Merged
Merged
Conversation
mcpherrinm
approved these changes
Jun 2, 2026
andygabby
approved these changes
Jun 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated GitHub Actions workflow to lint GitHub Actions definitions with zizmor, and updates existing CI workflows to better align with hardened GitHub Actions recommendations (pinning action SHAs and disabling credential persistence).
Changes:
- Add
.github/workflows/zizmor.ymlto runzizmorin CI using a pinned container image digest. - Pin
actions/checkout,actions/setup-python, andactions/setup-goto specific commit SHAs and setpersist-credentials: false. - Introduce workflow-level
permissions: {}declarations (currently problematic).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/zizmor.yml | Adds a zizmor lint workflow running via pinned Docker image; introduces workflow permissions config. |
| .github/workflows/pr_tools.yml | Pins action SHAs + disables persisted credentials; introduces workflow permissions config. |
| .github/workflows/lint.yml | Pins action SHAs + disables persisted credentials; introduces workflow permissions config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aarongable
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.