chore: update action versions

Author: ldez

.github/workflows/checks.yml

@@ -11,13 +11,12 @@ permissions:
   pull-requests: read
 env:
   CGO_ENABLED: 0
-  GOLANGCI_LINT_VERSION: v2.9.0
-  SHELLCHECK_SCRIPTS: ./*.sh
+  GOLANGCI_LINT_VERSION: v2.12
 jobs:
   go-lint-checks:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
@@ -28,15 +27,12 @@ jobs:
   go-mod-checks:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
       - name: Check if go.mod is tidy
-        run: |
-          go mod tidy
-          git diff --exit-code go.mod go.sum ||
-            (echo "::error::go.mod and go.sum need to be tidy" && exit 1)
+        run: go mod tidy --diff
       - name: Check if vendor directory is up to date
         run: |
           go mod vendor

.github/workflows/go-cross.yml

@@ -25,7 +25,7 @@ jobs:
           - windows-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
       - name: Set up Go
         uses: actions/setup-go@v6
         with:

.github/workflows/release.yml

@@ -32,7 +32,7 @@ jobs:
           - linux
           - windows
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: actions/setup-go@v6
         with:
           check-latest: true
@@ -48,7 +48,7 @@ jobs:
       - name: Display ${{ matrix.app }} artifacts
         run: tree /tmp/dist
       - name: Store ${{ matrix.app }} artifacts
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: ${{ matrix.app }}-${{ matrix.go-os }}-${{ matrix.go-arch }}
           path: /tmp/dist
@@ -64,9 +64,9 @@ jobs:
         - app: pebble-challtestsrv
           expose_ports: "5001 5002 5003 8053 8055 8443"
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Download ${{ matrix.app }} artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           merge-multiple: true
           path: /tmp/dist
@@ -75,7 +75,7 @@ jobs:
         run: tree /tmp/dist
       - name: Docker meta
         id: meta
-        uses: docker/metadata-action@v5
+        uses: docker/metadata-action@v6
         with:
           images: ${{ env.DOCKER_IMAGE_BASENAME }}/${{ matrix.app }}
           # generate Docker tags based on the following events/attributes
@@ -86,9 +86,9 @@ jobs:
             type=sha
             type=raw,value=latest
       - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v4
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
       - name: Login to GitHub Container Registry
         run: printenv GITHUB_TOKEN | docker login -u "$GITHUB_ACTOR" --password-stdin ghcr.io
         env:
@@ -131,7 +131,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
       - name: Display build artifacts
         run: tree .
       - name: Create release

.github/workflows/tests.yml

@@ -18,10 +18,10 @@ jobs:
           echo "127.0.0.1 elpmaxe.letsencrypt.org" | sudo tee -a /etc/hosts
       # https://github.com/marketplace/actions/checkout
       - name: Check out code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       # https://github.com/marketplace/actions/setup-go-environment
       - name: Set up Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
       - name: Install packages
@@ -42,9 +42,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Set up Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
       - name: go install commands
@@ -63,12 +63,12 @@ jobs:
     name: Test lego with EAB
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
         with:
-          go-version-file: go.mod
+          go-version: stable
       - name: Install lego cli
-        run: go install github.com/go-acme/lego/v4/cmd/lego@latest
+        run: go install github.com/go-acme/lego/v5@latest
       - name: go install commands
         run: go install -v ./cmd/...
       - name: launch pebble
@@ -77,21 +77,20 @@ jobs:
           pebble -config test/config/pebble-config-external-account-bindings.json &
       - run: |
           LEGO_CA_CERTIFICATES=./test/certs/pebble.minica.pem \
-          lego --accept-tos \
+          lego run \
+               --accept-tos \
                --server=https://localhost:14000/dir \
-               --email="pebble-test@example.letsencrypt.org" \
                --domains=example.letsencrypt.org \
                --eab \
-                 --kid kid-3 \
-                 --hmac=HjudV5qnbreN-n9WyFSH-t4HXuEx_XFen45zuxY-G1h6fr74V3cUM_dVlwQZBWmc \
-               --http --http.port=:5002 \
-               run
+                 --eab.kid kid-3 \
+                 --eab.hmac=HjudV5qnbreN-n9WyFSH-t4HXuEx_XFen45zuxY-G1h6fr74V3cUM_dVlwQZBWmc \
+               --http --http.address=:5002
   go-linux:
     name: Run Go tests on Linux
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       # Run project unit tests (with the race detector enabled and atomic coverage profile collection)
       - name: unittests
         run: go test -v -race -covermode=atomic -coverprofile=profile.cov ./...

.golangci.yaml

@@ -21,7 +21,6 @@ linters:
     - gocyclo
     - goheader
     - gomoddirectives
-    - gomodguard
     - goprintffuncname
     - importas
     - inamedparam
@@ -51,12 +50,12 @@ linters:
       min-complexity: 25
     misspell:
       locale: US
+    goconst:
+      ignore-tests: true
   exclusions:
-    generated: lax
     presets:
       - comments
       - common-false-positives
-      - legacy
       - std-error-handling
     rules:
       - path: ca/ca.go
@@ -71,10 +70,6 @@ linters:
         text: string `Incorrect validation certificate for %s challenge. ` has \d occurrences, make it a constant
       - path: (.+)\.go$
         text: fmt.Sprintf can be replaced with string
-    paths:
-      - third_party$
-      - builtin$
-      - examples$
 issues:
   max-issues-per-linter: 0
   max-same-issues: 0
@@ -83,9 +78,3 @@ formatters:
     - gofmt
     - gofumpt
     - goimports
-  exclusions:
-    generated: lax
-    paths:
-      - third_party$
-      - builtin$
-      - examples$