Add accounturi to dns-persist-01 challenges - #544
Merged
Conversation
This has been added to draft 01: https://www.ietf.org/archive/id/draft-ietf-acme-dns-persist-01.html#section-3.1
Contributor
Author
|
I did test this with my client, with the compat shim for draft 00 deactivated (my original code rejected challenges with the wrong account URI, until I tested it against Pebble :) ). |
beautifulentropy
self-requested a review
April 20, 2026 15:52
beautifulentropy
previously approved these changes
Apr 20, 2026
beautifulentropy
left a comment
beautifulentropy
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, this looks good to me.
aarongable
reviewed
Apr 20, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
Code change LGTM, but we really need to make sure that no one thinks merely reflecting the Host: header into the challenge's canonical accountURI is actually acceptable, so I'd like a comment something like the suggestion below to be included.
… Pebble, but not in general. Co-authored-by: Aaron Gable <aaron@aarongable.com>
aarongable
approved these changes
Apr 20, 2026
beautifulentropy
approved these changes
Apr 20, 2026
Contributor
Author
|
@beautifulentropy @aarongable thanks for reviewing and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been added to draft 01: https://www.ietf.org/archive/id/draft-ietf-acme-dns-persist-01.html#section-3.1 vs. https://www.ietf.org/archive/id/draft-ietf-acme-dns-persist-00.html#section-3.1
Diff: https://author-tools.ietf.org/iddiff?url1=draft-ietf-acme-dns-persist-00&url2=draft-ietf-acme-dns-persist-01