Sprint 3: Update alpine version and logout & login return type#77
Open
EleisonC wants to merge 4 commits into
Open
Sprint 3: Update alpine version and logout & login return type#77EleisonC wants to merge 4 commits into
EleisonC wants to merge 4 commits into
Conversation
Ensure cargo-chef is installed with locked dependencies.
EleisonC
changed the title
| let password = match Password::parse(request.password) { | ||
| Ok(password) => password, | ||
| Err(_) => return (jar, Err(AuthAPIError::InvalidCredentials)), | ||
| Err(_) => return Err(AuthAPIError::InvalidCredentials), |
Owner
There was a problem hiding this comment.
We can now do something like
let password = match Password::parse(request.password).map_err(|_| => AuthAPIError::InvalidCredentials)?;
Contributor
Author
There was a problem hiding this comment.
I agree, looks more idiomatic, thank you for the suggestion.
I will update it to
let password = Password::parse(request.password).map_err(|_| AuthAPIError::InvalidCredentials)?;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the return types for login and logout route functions addressed in #37
Why the Dockerfile changes?
cargo-chef's dependencycargo-platform@0.3.3requiresrustc 1.91, so the build failed onrust:1.90-alpine. Bumped to1.91and added--lockedto pincargo-chefto its lockfile, preventing future dependency resolution surprises.What are the related ClickUp changes?
Updated
auth-service/src/routes/login.rsUpdate return type
Updated
auth-service/src/routes/logout.rsUpdate return type