fix(app-server): isolate runtime skill scopes#3296
Draft
sarahwooders wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the remaining app-server runtime isolation needed by SDK-managed reflection workers:
skill_sourcesonruntime_start, preserving an explicit empty array as "no skills";runtime_startas a readiness boundary for memfs-enabled agent creation, waiting for the checkout before returning it to SDK callers.Why
PR #3285 added memfs-less worker creation and explicit per-session memory scopes, but the app-server still ignored the SDK's per-session skill-source override. Reflection workers created with
skillSources: []therefore received normal bundled/global/agent/project skills instead of an empty skill set.Separately,
runtime_startreturned before asynchronous MemFS setup completed. An SDK caller could seed and commit initial files, only for the delayed checkout to replace that working tree.Impact
SDK pipelines can run concurrent worker sessions against isolated memory clones without attaching Letta Code skills, including on approval-recovery turns. Newly created memfs-enabled agents are safe to initialize as soon as
runtime_startresolves.This is the focused harness follow-up needed by letta-ai/letta-agent-sdk#179.
Test plan
bun test src/agent/message-client-skills.test.ts src/app-server-client.test.ts src/websocket/listen-client-protocol.test.ts src/websocket/listener/protocol-inbound.test.ts— 239 pass, 0 failbun run check— all 10 checks pass